[Mac] Make --apps-keep-chrome-alive on by default.

[Mac] Make --apps-keep-chrome-alive on by default.

BUG=333429
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283326

[tapted, 2014-07-10 07:18:55]

Should we fix http://crbug.com/362444 first?

I still get weird behavior in Canary with this flag and steps:

1. hotdog -> help -> report an issue
2. select 'Choose File'
3. Dock -> Chrome -> Quit
4. Notification -> Quit all Apps

(I think the 'Quit all apps' bit is infinite-looping since the window close is
ignored).

[jackhou1, 2014-07-14 02:35:22]

On 2014/07/10 07:18:55, tapted wrote:
> Should we fix http://crbug.com/362444 first?
> 
> I still get weird behavior in Canary with this flag and steps:
> 
> 1. hotdog -> help -> report an issue
> 2. select 'Choose File'
> 3. Dock -> Chrome -> Quit
> 4. Notification -> Quit all Apps
> 
> (I think the 'Quit all apps' bit is infinite-looping since the window close is
> ignored).

Done.

[tapted, 2014-07-14 02:53:20]

lgtm

[jackhou1, 2014-07-14 03:09:12]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-07-14 03:09:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jackhou@chromium.org/385533002/1

[commit-bot: I haz the power, 2014-07-14 10:13:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-14 13:54:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-14 13:54:09]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[jackhou1, 2014-07-14 22:55:58]

This needs to be disabled on tests.

Leaving the flag in to enable it for QuitWithAppsControllerInteractiveTest.

PTAL

[tapted, 2014-07-14 23:23:29]

https://codereview.chromium.org/385533002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc (right):

https://codereview.chromium.org/385533002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc:110:
switches::kAppsKeepChromeAlive)) {
If we keep the switch, I think we should rename it. Inverting it would be a
pain, but it should be clear it's just for testing. Perhaps
kAppsKeepChromeAliveInTests? (and the corresponding string literal)

Switches are also meant to be temporary unless there's a good reason.. there
might be another switch that's suitable, or some pref state. But nothing is
grabbing me - you'd have to add logic somewhere, so a switch is probably fine.

[jackhou1, 2014-07-15 05:21:37]

https://codereview.chromium.org/385533002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc (right):

https://codereview.chromium.org/385533002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc:110:
switches::kAppsKeepChromeAlive)) {
On 2014/07/14 23:23:29, tapted wrote:
> If we keep the switch, I think we should rename it. Inverting it would be a
> pain, but it should be clear it's just for testing. Perhaps
> kAppsKeepChromeAliveInTests? (and the corresponding string literal)
> 
> Switches are also meant to be temporary unless there's a good reason.. there
> might be another switch that's suitable, or some pref state. But nothing is
> grabbing me - you'd have to add logic somewhere, so a switch is probably fine.

Done.

[tapted, 2014-07-15 05:41:27]

lgtm

[jackhou1, 2014-07-15 06:35:31]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-07-15 06:37:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jackhou@chromium.org/385533002/40001

[commit-bot: I haz the power, 2014-07-15 12:39:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-15 17:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-15 17:55:22]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[jackhou1, 2014-07-16 01:31:13]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-07-16 01:33:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jackhou@chromium.org/385533002/40001

[commit-bot: I haz the power, 2014-07-16 04:08:44]

Change committed as 283326