[Mac] Make --apps-keep-chrome-alive on by default.

chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h"
 
 #include "apps/app_window.h"
 #include "apps/app_window_registry.h"
 #include "apps/ui/native_app_window.h"
 #include "base/command_line.h"
@@ skipping 86 matching lines @@
   return NULL;
 }
 
 std::string QuitWithAppsController::id() const {
   return kQuitWithAppsNotificationID;
 }
 
 bool QuitWithAppsController::ShouldQuit() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
-  if (!CommandLine::ForCurrentProcess()->HasSwitch(
+  // Quit immediately if this is a test.
+  if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType) &&
+      !CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kAppsKeepChromeAlive)) {

[tapted, 2014/07/14 23:23:29]

If we keep the switch, I think we should rename it. Inverting it would be a
pain, but it should be clear it's just for testing. Perhaps
kAppsKeepChromeAliveInTests? (and the corresponding string literal)

Switches are also meant to be temporary unless there's a good reason.. there
might be another switch that's suitable, or some pref state. But nothing is
grabbing me - you'd have to add logic somewhere, so a switch is probably fine.

[jackhou1, 2014/07/15 05:21:37]

Done.

-    g_browser_process->local_state()->ClearPref(
-        prefs::kNotifyWhenAppsKeepChromeAlive);
     return true;
   }
 
   // Quit immediately if there are no windows or the confirmation has been
   // suppressed.
   if (!apps::AppWindowRegistry::IsAppWindowRegisteredInAnyProfile(0))
     return true;
 
   // If there are browser windows, and this notification has been suppressed for
   // this session or permanently, then just return false to prevent Chrome from
@@ skipping 18 matching lines @@
 
   // Always return false, the notification UI can be used to quit all apps which
   // will cause Chrome to quit.
   return false;
 }
 
 // static
 void QuitWithAppsController::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterBooleanPref(prefs::kNotifyWhenAppsKeepChromeAlive, true);
 }