Support FontRenderParams on Win; fix RenderTextHarfBuzz.

Support FontRenderParams on Win; fix RenderTextHarfBuzz.

Set FontRenderParams in RenderTextHarfBuzz on Linux.
(required for text aliasing and subpixel settings)

Replace font_smoothing_win with font_render_params_win.cc
(unify the cross-platform methods of getting this info)

BUG=391868, 321868
TEST=Chrome OS tray button text looks good with --enable-harfbuzz-rendertext; no other font appearance changes on Win/Linux/CrOS and --enable-harfbuzz-rendertext uses the same font rendering settings as the default Uniscribe/Pango RenderText implementations.
R=derat@chromium.org,ckocagil@chromium.org
TBR=asvitkine@chromium.org,boliu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282223

[msw, 2014-07-09 23:30:22]

Hey Dan and Cem, please take a look; thanks!

[Daniel Erat, 2014-07-09 23:38:54]

lgtm

nice, i'm happy to see this get unified. i have a change that i'll probably send
out soon that adds a method for getting a FontRenderParams for a combination of
families, point size, and pixel size, but i'll just make it return the default
on windows (as it already does on android).

https://codereview.chromium.org/385463002/diff/80001/ui/gfx/render_text_harfb...
File ui/gfx/render_text_harfbuzz.cc (right):

https://codereview.chromium.org/385463002/diff/80001/ui/gfx/render_text_harfb...
ui/gfx/render_text_harfbuzz.cc:781: #if defined(OS_WIN) || defined(OS_LINUX)
does RenderTextHarfbuzz get used for other platforms?

[msw, 2014-07-09 23:53:00]

TBR: asvitkine for ui/gfx/ and boliu for android_webview/.

https://codereview.chromium.org/385463002/diff/80001/ui/gfx/render_text_harfb...
File ui/gfx/render_text_harfbuzz.cc (right):

https://codereview.chromium.org/385463002/diff/80001/ui/gfx/render_text_harfb...
ui/gfx/render_text_harfbuzz.cc:781: #if defined(OS_WIN) || defined(OS_LINUX)
On 2014/07/09 23:38:53, Daniel Erat wrote:
> does RenderTextHarfbuzz get used for other platforms?

Yeah, RenderTextHarfbuzz works on Mac too.

[msw, 2014-07-09 23:53:16]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-07-09 23:54:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/385463002/100001

[boliu, 2014-07-09 23:56:16]

android_webview lgtm

https://codereview.chromium.org/385463002/diff/100001/ui/gfx/font_render_para...
File ui/gfx/font_render_params.h (right):

https://codereview.chromium.org/385463002/diff/100001/ui/gfx/font_render_para...
ui/gfx/font_render_params.h:5: #ifndef UI_GFX_FONT_RENDER_PARAMS_LINUX_H_
Should these header defines be fixed?

[msw, 2014-07-09 23:59:48]

The CQ bit was unchecked by msw@chromium.org

[msw, 2014-07-10 00:02:29]

https://codereview.chromium.org/385463002/diff/100001/ui/gfx/font_render_para...
File ui/gfx/font_render_params.h (right):

https://codereview.chromium.org/385463002/diff/100001/ui/gfx/font_render_para...
ui/gfx/font_render_params.h:5: #ifndef UI_GFX_FONT_RENDER_PARAMS_LINUX_H_
On 2014/07/09 23:56:15, boliu wrote:
> Should these header defines be fixed?

Good catch! Done.

[msw, 2014-07-10 00:02:36]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-07-10 00:06:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/385463002/120001

[commit-bot: I haz the power, 2014-07-10 02:57:05]

Change committed as 282223

[Alexei Svitkine (slow), 2014-07-14 15:00:53]

https://codereview.chromium.org/385463002/diff/120001/ui/gfx/font_render_para...
File ui/gfx/font_render_params_win.cc (right):

https://codereview.chromium.org/385463002/diff/120001/ui/gfx/font_render_para...
ui/gfx/font_render_params_win.cc:61:
gfx::SingletonHwnd::GetInstance()->RemoveObserver(this);
Wait, what if the settings change again? Wouldn't the observer have been removed
and we wouldn't see it?

[ckocagil, 2014-07-14 16:13:47]

https://codereview.chromium.org/385463002/diff/120001/ui/gfx/font_render_para...
File ui/gfx/font_render_params_win.cc (right):

https://codereview.chromium.org/385463002/diff/120001/ui/gfx/font_render_para...
ui/gfx/font_render_params_win.cc:61:
gfx::SingletonHwnd::GetInstance()->RemoveObserver(this);
On 2014/07/14 15:00:53, Alexei Svitkine wrote:
> Wait, what if the settings change again? Wouldn't the observer have been
removed
> and we wouldn't see it?

There's no need to invalidate the already invalidated |params_| (i.e when
params_ is NULL). GetParams() adds the observer back, so the observer is alive
whenever |params_| is valid.

[Alexei Svitkine (slow), 2014-07-14 16:32:21]

https://codereview.chromium.org/385463002/diff/120001/ui/gfx/font_render_para...
File ui/gfx/font_render_params_win.cc (right):

https://codereview.chromium.org/385463002/diff/120001/ui/gfx/font_render_para...
ui/gfx/font_render_params_win.cc:61:
gfx::SingletonHwnd::GetInstance()->RemoveObserver(this);
On 2014/07/14 16:13:47, ckocagil wrote:
> On 2014/07/14 15:00:53, Alexei Svitkine wrote:
> > Wait, what if the settings change again? Wouldn't the observer have been
> removed
> > and we wouldn't see it?
> 
> There's no need to invalidate the already invalidated |params_| (i.e when
> params_ is NULL). GetParams() adds the observer back, so the observer is alive
> whenever |params_| is valid.

Ah, got it!