Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 38533002: Revert 230334 "Improve and simplify AudioOutputDispatcher." (Closed)

Created:
7 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 2 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 230334 "Improve and simplify AudioOutputDispatcher." Likely cause of flakiness on Win7 Debug (NVIDIA) bot. BUG=310838 > Improve and simplify AudioOutputDispatcher. > > AudioOutputDispatcher does a number of things which no longer make > sense in a world where we don't create tons of physical streams: > > - Streams are not immediately recycled but instead inserted > into a paused queue. This was done to improve cycle time > when physical streams were rapidly paused and played. > > - If any stream was paused previously and then closed, every > new stream opened will open two streams. Again this was to > improve cycle time for paused and played streams. > > For HTML5, this has been handled by AudioRendererMixer for some time. > WebRTC, WebAudio, and PPAPI generally don't start and stop streams > repeatedly in a way that this code is beneficial. > > As such, all of that code has been removed. As a hedge, one stream > is left open after Close() until the close timer fires. This allows > cycle time to be improved in cases of interleaved Start/Stop cycles. > > I've additionally cleaned up the code to use std::algorithm where > applicable, removed unnecessary WeakPtr setup, and cleaned up the > unittests. > > BUG=none > TEST=audio plays, unittests pass. > > Review URL: https://codereview.chromium.org/27605002 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -139 lines) Patch
M trunk/src/media/audio/audio_output_dispatcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/media/audio/audio_output_dispatcher_impl.h View 3 chunks +24 lines, -11 lines 0 comments Download
M trunk/src/media/audio/audio_output_dispatcher_impl.cc View 5 chunks +90 lines, -35 lines 0 comments Download
M trunk/src/media/audio/audio_output_proxy_unittest.cc View 24 chunks +167 lines, -93 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
7 years, 2 months ago (2013-10-23 23:05:20 UTC) #1
Ken Russell (switch to Gerrit)
7 years, 2 months ago (2013-10-23 23:05:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r230543.

Powered by Google App Engine
This is Rietveld 408576698