Issue 385113005: Remove @Nullable annoation on readAndDispatchMessage

Issue 385113005: Remove @Nullable annoation on readAndDispatchMessage (Closed)

Created:
6 years, 5 months ago by qsr

Modified:
6 years, 5 months ago

Reviewers:
rmcilroy

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove @Nullable annoation on readAndDispatchMessage The public API of mojo should not depend on any third-party library. This CL remove the @Nullable annoation on Message#readAndDispatchMessage R=rmcilroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282625

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -11 lines)			Patch
	M	mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
	M	mojo/mojo_public.gypi	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rmcilroy

lgtm https://codereview.chromium.org/385113005/diff/1/mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java File mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java (right): https://codereview.chromium.org/385113005/diff/1/mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java#newcode44 mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java:44: * |MessageReceiver| is null, the message is lost. ...

6 years, 5 months ago (2014-07-11 12:10:35 UTC) #2

qsr

https://codereview.chromium.org/385113005/diff/1/mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java File mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java (right): https://codereview.chromium.org/385113005/diff/1/mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java#newcode44 mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java:44: * |MessageReceiver| is null, the message is lost. On ...

6 years, 5 months ago (2014-07-11 12:28:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/385113005/20001

6 years, 5 months ago (2014-07-11 12:28:38 UTC) #5

Message was sent while issue was closed.

Change committed as 282625

Expand Messages | Collapse Messages