Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java

Issue 385113005: Remove @Nullable annoation on readAndDispatchMessage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Follow review Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/mojo_public.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java
diff --git a/mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java b/mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java
index f826a8e034c9215a8a8e6496e05c716619a32d0d..ee687070127fff4b5f6b896de6c61c493a6584d4 100644
--- a/mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java
+++ b/mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java
@@ -12,8 +12,6 @@ import org.chromium.mojo.system.MojoResult;
import java.nio.ByteBuffer;
import java.util.List;
-import javax.annotation.Nullable;
-
/**
* A raw message to be sent/received from a {@link MessagePipeHandle}.
*/
@@ -44,9 +42,11 @@ public final class Message {
/**
* Read a message, and pass it to the given |MessageReceiver| if not null. If the
* |MessageReceiver| is null, the message is lost.
+ *
+ * @param receiver The {@link MessageReceiver} that will receive the read {@link Message}. Can
+ * be <code>null</code>, in which case the message is discarded.
*/
- public static int readAndDispatchMessage(MessagePipeHandle handle,
- @Nullable MessageReceiver receiver) {
+ public static int readAndDispatchMessage(MessagePipeHandle handle, MessageReceiver receiver) {
// TODO(qsr) Allow usage of a pool of pre-allocated buffer for performance.
ReadMessageResult result = handle.readMessage(null, 0, MessagePipeHandle.ReadFlags.NONE);
if (result.getMojoResult() != MojoResult.RESOURCE_EXHAUSTED) {
« no previous file with comments | « no previous file | mojo/mojo_public.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698