Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 385111: Merge 31792 - The ChromeFrameAutomationClient class needs to be refcounted as... (Closed)

Created:
11 years, 1 month ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
ananta
CC:
chromium-reviews_googlegroups.com, amit, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 31792 - The ChromeFrameAutomationClient class needs to be refcounted as it implements the PluginRequestHandler interface which is maintained by individual requests which can outlive the active document/activex instances. I ran into a crash where UrlmonUrlRequest was calling into an invalid PluginRequestHandler pointer which had been destroyed just before. We also need to ensure that UrlmonUrlRequest and ChromeFrameActiveXBase select the multi threaded model as AddRef/Release can be invoked from multiple threads. I also removed the CleanupAsyncRequests function in ChromeFrameAutomationClient and moved all the code to CleanupRequests, which ensures that we treat synchronous and asynchronous requests similarly. There are instances where an automation client instance is created and destroyed without being initialized which causes a spurious assert to fire in the Uninitialize function. I added a check in the Uninitialize function to return if the state is uninitialized. Bug=none Review URL: http://codereview.chromium.org/386014 TBR=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -78 lines) Patch
M chrome_frame/chrome_active_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_activex_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 5 chunks +8 lines, -18 lines 0 comments Download
M chrome_frame/chrome_frame_plugin.h View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome_frame/find_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
MM chrome_frame/find_dialog.cc View 2 chunks +21 lines, -21 lines 0 comments Download
M chrome_frame/np_proxy_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/plugin_url_request.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome_frame/test/chrome_frame_automation_mock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/chrome_frame_unittests.cc View 11 chunks +17 lines, -16 lines 0 comments Download
M chrome_frame/urlmon_url_request.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
11 years, 1 month ago (2009-11-14 00:22:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698