Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7081)

Unified Diff: chrome_frame/chrome_frame_plugin.h

Issue 385111: Merge 31792 - The ChromeFrameAutomationClient class needs to be refcounted as... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/245/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_frame_automation.cc ('k') | chrome_frame/find_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_frame_plugin.h
===================================================================
--- chrome_frame/chrome_frame_plugin.h (revision 31968)
+++ chrome_frame/chrome_frame_plugin.h (working copy)
@@ -5,6 +5,7 @@
#ifndef CHROME_FRAME_CHROME_FRAME_PLUGIN_H_
#define CHROME_FRAME_CHROME_FRAME_PLUGIN_H_
+#include "base/ref_counted.h"
#include "base/win_util.h"
#include "chrome_frame/chrome_frame_automation.h"
#include "chrome_frame/utils.h"
@@ -32,7 +33,7 @@
bool Initialize() {
DCHECK(!automation_client_.get());
- automation_client_.reset(CreateAutomationClient());
+ automation_client_ = CreateAutomationClient();
if (!automation_client_.get()) {
NOTREACHED() << "new ChromeFrameAutomationClient";
return false;
@@ -44,7 +45,7 @@
void Uninitialize() {
if (automation_client_.get()) {
automation_client_->Uninitialize();
- automation_client_.reset();
+ automation_client_ = NULL;
}
}
@@ -191,7 +192,7 @@
protected:
// Our gateway to chrome land
- scoped_ptr<ChromeFrameAutomationClient> automation_client_;
+ scoped_refptr<ChromeFrameAutomationClient> automation_client_;
// Url of the containing document.
std::string document_url_;
« no previous file with comments | « chrome_frame/chrome_frame_automation.cc ('k') | chrome_frame/find_dialog.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698