Issue 385073006: Improve tracing of xvfb.py

Issue 385073006: Improve tracing of xvfb.py (Closed)

Created:
6 years, 5 months ago by Peter Mayo

Modified:
6 years, 5 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Improve tracing of xvfb.py Route stdout to stdout. Report error code. Reword failure to test message. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283022

Patch Set 4 : Add stopping/status of Xvfb on display check failure #

Patch Set 5 : Scoping wrong, fixed #

Total comments: 2

Patch Set 6 : Renamed variable #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	testing/xvfb.py	View	1 2 3 4 5	2 chunks	+20 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm, thanks! https://codereview.chromium.org/385073006/diff/70001/testing/xvfb.py File testing/xvfb.py (right): https://codereview.chromium.org/385073006/diff/70001/testing/xvfb.py#newcode102 testing/xvfb.py:102: proc = start_xvfb(xvfb, display) I'd prefer xvfb_proc ...

6 years, 5 months ago (2014-07-14 16:54:35 UTC) #3

Peter Mayo

https://codereview.chromium.org/385073006/diff/70001/testing/xvfb.py File testing/xvfb.py (right): https://codereview.chromium.org/385073006/diff/70001/testing/xvfb.py#newcode102 testing/xvfb.py:102: proc = start_xvfb(xvfb, display) On 2014/07/14 16:54:35, M-A Ruel ...

6 years, 5 months ago (2014-07-14 16:58:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/385073006/90001

6 years, 5 months ago (2014-07-14 16:59:45 UTC) #6

Message was sent while issue was closed.

Change committed as 283022

Expand Messages | Collapse Messages