Issue 385043002: Form validation bubble should be closed when RenderView is terminated.

Issue 385043002: Form validation bubble should be closed when RenderView is terminated. (Closed)

Created:
6 years, 5 months ago by tkent

Modified:
6 years, 5 months ago

Reviewers:
keishi, jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Form validation bubble should be closed when RenderView is terminated. Blink closes it when a page is disposed. However, Blink can do nothing when the renderer process is terminated. Chromium needs to close it in such case. BUG=355564 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282690

Patch Set 1 : #

Patch Set 2 : Add a test #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
	M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	content/browser/web_contents/web_contents_impl_unittest.cc	View	1	2 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

tkent

Keishi, would you review this change please? Jochen, would you approve this as an owner ...

6 years, 5 months ago (2014-07-11 02:58:20 UTC) #1

tkent

On 2014/07/11 09:20:51, jochen wrote: > is it possible to test this? Hmm, probably we ...

6 years, 5 months ago (2014-07-11 13:08:06 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/385043002/40001

6 years, 5 months ago (2014-07-11 19:48:01 UTC) #8

Message was sent while issue was closed.

Change committed as 282690

Expand Messages | Collapse Messages