content/browser/web_contents/web_contents_impl.cc - Issue 385043002: Form validation bubble should be closed when RenderView is terminated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 385043002: Form validation bubble should be closed when RenderView is terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index bd4f19356302ab5b2f00c5ccc3ce19452da87975..9a557d277f704473ed3a9f5724e2f74821b5a481 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3394,6 +3394,9 @@ void WebContentsImpl::RenderViewTerminated(RenderViewHost* rvh,

if (dialog_manager_)

dialog_manager_->CancelActiveAndPendingDialogs(this);

+ if (delegate_)

+ delegate_->HideValidationMessage(this);

SetIsLoading(rvh, false, true, NULL);

NotifyDisconnected();

SetIsCrashed(status, error_code);

« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl_unittest.cc » ('j') | no next file with comments »