Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 385041: Merge crash fix to 3.0.... (Closed)

Created:
11 years, 1 month ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
laforge
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge crash fix to 3.0. BUG=20511 TEST=Type a character in the omnibox, minimize the window, and restore it. The dropdown should have disappeared. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -49 lines) Patch
MM chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h View 2 chunks +5 lines, -3 lines 0 comments Download
MM chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_win.h View 1 chunk +4 lines, -12 lines 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_win.cc View 2 chunks +7 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Kasting
Can you try applying/building/testing this to make sure it works before I check in?
11 years, 1 month ago (2009-11-11 19:07:32 UTC) #1
Peter Kasting
Reviewers: laforge, Message: Can you try applying/building/testing this to make sure it works before I ...
11 years, 1 month ago (2009-11-11 19:07:51 UTC) #2
laforge
11 years, 1 month ago (2009-11-11 20:06:26 UTC) #3
LGTM.  Feel free to commit it, I'll kick off a new build, worst case I can
revert.

Kind Regards,

Anthony Laforge
Technical Program Manager
Mountain View, CA


On Wed, Nov 11, 2009 at 11:07 AM, <pkasting@chromium.org> wrote:

> Reviewers: laforge,
>
> Message:
> Can you try applying/building/testing this to make sure it works before I
> check
> in?
>
> Description:
> Merge crash fix to 3.0.
>
> BUG=20511
> TEST=Type a character in the omnibox, minimize the window, and restore it.
>  The
> dropdown should have disappeared.
>
> Please review this at http://codereview.chromium.org/385041
>
> SVN Base: svn://svn.chromium.org/chrome/branches/195/src/
>
> Affected files:
>  MM    chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h
>  MM
>  chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc
>  M     chrome/browser/views/autocomplete/autocomplete_popup_win.h
>  M     chrome/browser/views/autocomplete/autocomplete_popup_win.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698