Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4679)

Unified Diff: chrome/browser/views/autocomplete/autocomplete_popup_win.cc

Issue 385041: Merge crash fix to 3.0.... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/195/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/autocomplete/autocomplete_popup_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/autocomplete/autocomplete_popup_win.cc
===================================================================
--- chrome/browser/views/autocomplete/autocomplete_popup_win.cc (revision 31682)
+++ chrome/browser/views/autocomplete/autocomplete_popup_win.cc (working copy)
@@ -14,24 +14,17 @@
// AutocompletePopupWin, public:
AutocompletePopupWin::AutocompletePopupWin(
- AutocompletePopupContentsView* contents)
- : contents_(contents) {
- set_delete_on_destroy(false);
+ AutocompleteEditView* edit_view,
+ AutocompletePopupContentsView* contents) {
+ // Create the popup.
+ set_delete_on_destroy(false); // Owned by |contents|.
set_window_style(WS_POPUP | WS_CLIPCHILDREN);
set_window_ex_style(WS_EX_TOOLWINDOW | WS_EX_LAYERED);
-}
-
-AutocompletePopupWin::~AutocompletePopupWin() {
-}
-
-void AutocompletePopupWin::Init(AutocompleteEditViewWin* edit_view,
- views::View* contents) {
- // Create the popup
WidgetWin::Init(edit_view->parent_view()->GetWidget()->GetNativeView(),
- contents_->GetPopupBounds());
+ contents->GetPopupBounds());
// The contents is owned by the LocationBarView.
contents_->SetParentOwned(false);
- SetContentsView(contents_);
+ SetContentsView(contents);
// When an IME is attached to the rich-edit control, retrieve its window
// handle and show this popup window under the IME windows.
@@ -43,12 +36,7 @@
SWP_NOSIZE | SWP_NOMOVE | SWP_NOACTIVATE | SWP_SHOWWINDOW);
}
-void AutocompletePopupWin::Show() {
- // Move the popup to the place appropriate for the window's current position -
- // it may have been moved since it was last shown.
- SetBounds(contents_->GetPopupBounds());
- if (!IsVisible())
- WidgetWin::Show();
+AutocompletePopupWin::~AutocompletePopupWin() {
}
////////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « chrome/browser/views/autocomplete/autocomplete_popup_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698