Speculative fix for a common crash. We were leaking the

Speculative fix for a common crash. We were leaking the
BrowserActionView because RemoveChild() does not delete it.
This could maybe cause OnImageLoaded() to be called when
there is no parent. I couldn't see any other path that could
lead to that.

BUG=27167
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31651

[Aaron Boodman, 2009-11-11 02:00:40]

Reviewers: Matt Perry,

Description:
Speculative fix for a common crash. We were leaking the
BrowserActionView because RemoveChild() does not delete it.
This could maybe cause OnImageLoaded() to be called when
there is no parent. I couldn't see any other path that could
lead to that.

BUG=27167
TEST=none

Please review this at http://codereview.chromium.org/385031

Affected files:
   M chrome/browser/views/browser_actions_container.cc


Index: chrome/browser/views/browser_actions_container.cc
diff --git a/chrome/browser/views/browser_actions_container.cc  
b/chrome/browser/views/browser_actions_container.cc
index  
dbae46b7758de02ad39646c5475976f734d32e12..561df9b919729e05f1f1a3cae58f7109630879ba
 
100644
--- a/chrome/browser/views/browser_actions_container.cc
+++ b/chrome/browser/views/browser_actions_container.cc
@@ -300,6 +300,7 @@ void  
BrowserActionsContainer::RemoveBrowserAction(Extension* extension) {
         ++iter) {
      if ((*iter)->button()->extension() == extension) {
        RemoveChildView(*iter);
+      delete *iter;
        browser_action_views_.erase(iter);
        if (GetParent())
          GetParent()->SchedulePaint();

[Matt Perry, 2009-11-11 02:04:22]

LGTM

[Matt Perry, 2009-11-11 02:04:40]

LGTM

http://codereview.chromium.org/385031