Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: chrome/browser/views/browser_actions_container.cc

Issue 385031: Speculative fix for a common crash. We were leaking the (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/browser_actions_container.cc
diff --git a/chrome/browser/views/browser_actions_container.cc b/chrome/browser/views/browser_actions_container.cc
index dbae46b7758de02ad39646c5475976f734d32e12..561df9b919729e05f1f1a3cae58f7109630879ba 100644
--- a/chrome/browser/views/browser_actions_container.cc
+++ b/chrome/browser/views/browser_actions_container.cc
@@ -300,6 +300,7 @@ void BrowserActionsContainer::RemoveBrowserAction(Extension* extension) {
++iter) {
if ((*iter)->button()->extension() == extension) {
RemoveChildView(*iter);
+ delete *iter;
browser_action_views_.erase(iter);
if (GetParent())
GetParent()->SchedulePaint();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698