Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 385004: Remove sliced string string type... (Closed)

Created:
8 years ago by Søren Thygesen Gjesse
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove sliced string string type As a first step to reduce the complexity of the string hierachy the sliced string type is removed. Whenever a sub-string is created it is allocated as a fresh flat string. Committed: http://code.google.com/p/v8/source/detail?r=3259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -647 lines) Patch
M src/conversions.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.h View 3 chunks +0 lines, -22 lines 0 comments Download
M src/heap.cc View 4 chunks +16 lines, -66 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 3 chunks +5 lines, -17 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.h View 16 chunks +6 lines, -145 lines 0 comments Download
M src/objects.cc View 14 chunks +6 lines, -140 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/objects-inl.h View 8 chunks +1 line, -47 lines 0 comments Download
M src/regexp-macro-assembler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M src/string.js View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-strings.cc View 3 chunks +0 lines, -167 lines 0 comments Download
Trybot results:

Messages

Total messages: 6 (0 generated)
Søren Thygesen Gjesse
8 years ago (2009-11-10 11:52:06 UTC) #1
Mads Ager (chromium)
LGTM
8 years ago (2009-11-10 12:05:35 UTC) #2
Mads Ager (chromium)
Except that there must be an arm and an x64 file missing?
8 years ago (2009-11-10 12:05:56 UTC) #3
Søren Thygesen Gjesse
On 2009/11/10 12:05:56, Mads Ager wrote: > Except that there must be an arm and ...
8 years ago (2009-11-10 12:53:40 UTC) #4
Christian Plesner Hansen
And may I add: STV!
8 years ago (2009-11-10 13:09:01 UTC) #5
Søren Thygesen Gjesse
8 years ago (2009-11-10 13:24:19 UTC) #6
On 2009/11/10 12:53:40, Søren Gjesse wrote:
> On 2009/11/10 12:05:56, Mads Ager wrote:
> > Except that there must be an arm and an x64 file missing?
> 
> There is not, as x64 does not check for sliced strings and FastCharcodeAt goes
> directly to slow case on ARM.

Correction: src/x64/codegen-x64.cc added after all as it was changed. It was
sitting in another gcl changelist and the reason it did not check for sliced
strings was because I removed that from it.

Powered by Google App Engine
This is Rietveld efc10ee0f