Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop
Patch Set: Removed FormatSessionCacheKey function. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index db1b2b2477e9a92668b874113e83a359306c7585..7d7021ef4c10b188235a60256c1c7b70a4f0a2b4 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -2881,6 +2881,11 @@ bool SSLClientSocketNSS::GetSSLInfo(SSLInfo* ssl_info) {
return true;
}
+std::string SSLClientSocketNSS::GetSessionCacheKey() const {
+ NOTREACHED();
+ return "";
Ryan Sleevi 2014/07/25 21:40:07 std::string() - but it does seem very weird, since
mshelley 2014/07/28 21:05:32 This method was changed from a static method to a
Ryan Sleevi 2014/07/28 23:47:38 Surprisingly hidden, https://code.google.com/p/chr
+}
+
bool SSLClientSocketNSS::InSessionCache() const {
// For now, always return true so that SSLConnectJobs are never held back.
return true;

Powered by Google App Engine
This is Rietveld 408576698