This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed,

net/socket/ssl_client_socket_nss.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file includes code SSLClientSocketNSS::DoVerifyCertComplete() derived
 // from AuthCertificateCallback() in
 // mozilla/security/manager/ssl/src/nsNSSCallbacks.cpp.
 
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
@@ skipping 2863 matching lines @@
                 << " for cipherSuite " << cipher_suite;
   }
 
   ssl_info->handshake_type = core_->state().resumed_handshake ?
       SSLInfo::HANDSHAKE_RESUME : SSLInfo::HANDSHAKE_FULL;
 
   LeaveFunction("");
   return true;
 }
 
+std::string SSLClientSocketNSS::GetSessionCacheKey() const {
+  NOTREACHED();
+  return "";

[Ryan Sleevi, 2014/07/25 21:40:07]

std::string() - but it does seem very weird, since we can and do format the
session key for NSS sockets.

[mshelley, 2014/07/28 21:05:32]

This method was changed from a static method to a method of
SSLClientSocketOpenSSL somewhere in https://codereview.chromium.org/353713005/
because there wasn't really any reason for it to be static. I can't actually
find any place in SSLClientSocketNSS where a cache key is created...but it
doesn't seem to have an equivalent static method that this could replace.

[Ryan Sleevi, 2014/07/28 23:47:38]

Surprisingly hidden,
https://code.google.com/p/chromium/codesearch#chromium/src/net/socket/ssl_cli...

+}
+
 bool SSLClientSocketNSS::InSessionCache() const {
   // For now, always return true so that SSLConnectJobs are never held back.
   return true;
 }
 
 void SSLClientSocketNSS::WatchSessionForCompletion(
     const base::Closure& callback) {
   NOTREACHED();
 }
 
@@ skipping 743 matching lines @@
 scoped_refptr<X509Certificate>
 SSLClientSocketNSS::GetUnverifiedServerCertificateChain() const {
   return core_->state().server_cert.get();
 }
 
 ServerBoundCertService* SSLClientSocketNSS::GetServerBoundCertService() const {
   return server_bound_cert_service_;
 }
 
 }  // namespace net