Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: net/socket/socket_test_util.h

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop
Patch Set: Rebase, fixed issue where messenger field wasn't set to NULL after deletion Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/socket_test_util.h
diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h
index 00905cd6dbb60b79d1d5b5220c9b7aa1078c7afb..9480c09bfe8e0ee2fe242b81aa0c72540eee9cb3 100644
--- a/net/socket/socket_test_util.h
+++ b/net/socket/socket_test_util.h
@@ -703,6 +703,7 @@ class MockClientSocket : public SSLClientSocket {
virtual void SetOmniboxSpeculation() OVERRIDE {}
// SSLClientSocket implementation.
+ virtual std::string GetSessionCacheKey() const OVERRIDE;
virtual bool InSessionCache() const OVERRIDE;
virtual void SetHandshakeCompletionCallback(const base::Closure& cb) OVERRIDE;
virtual void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info)
@@ -964,6 +965,7 @@ class MockSSLClientSocket : public MockClientSocket, public AsyncSocket {
virtual bool GetSSLInfo(SSLInfo* ssl_info) OVERRIDE;
// SSLClientSocket implementation.
+ virtual std::string GetSessionCacheKey() const OVERRIDE;
virtual bool InSessionCache() const OVERRIDE;
virtual void SetHandshakeCompletionCallback(const base::Closure& cb) OVERRIDE;
virtual void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info)
@@ -1008,6 +1010,7 @@ class MockSSLClientSocket : public MockClientSocket, public AsyncSocket {
bool new_npn_value_;
bool is_protocol_negotiated_set_;
NextProto protocol_negotiated_;
+ HostPortPair host_port_pair_;
CompletionCallback connect_callback_;
// Indicates what state of Connect the socket should enter.

Powered by Google App Engine
This is Rietveld 408576698