net/socket/client_socket_pool_base_unittest.cc - Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_base_unittest.cc

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop

Patch Set: Rebase, fixed issue where messenger field wasn't set to NULL after deletion Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/client_socket_pool_base_unittest.cc

diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc

index 5a672b44a4e99a30fd2583b9a545c84287b9d5b4..85d3be74b9f152a742d7e12d7511d2ff0e9e3527 100644

--- a/net/socket/client_socket_pool_base_unittest.cc

+++ b/net/socket/client_socket_pool_base_unittest.cc

@@ -457,7 +457,7 @@ class TestConnectJobFactory

virtual scoped_ptr<ConnectJob> NewConnectJob(

const std::string& group_name,

const TestClientSocketPoolBase::Request& request,

- ConnectJob::Delegate* delegate) const OVERRIDE {

+ ConnectJob::Delegate* delegate) OVERRIDE {

EXPECT_TRUE(!job_types_ || !job_types_->empty());

TestConnectJob::JobType job_type = job_type_;

if (job_types_ && !job_types_->empty()) {

« net/socket/client_socket_pool_base.cc ('K') | « net/socket/client_socket_pool_base.cc ('k') | net/socket/socket_test_util.h » ('j') | net/socket/socket_test_util.h » ('J')