Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3087)

Unified Diff: chrome/common/extensions/webstore_install_result.h

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/webstore_install_result.h
diff --git a/chrome/browser/extensions/webstore_install_result.h b/chrome/common/extensions/webstore_install_result.h
similarity index 74%
rename from chrome/browser/extensions/webstore_install_result.h
rename to chrome/common/extensions/webstore_install_result.h
index a9602e1ab69d49ee2cdc87c148d067688cf21f46..de5b55ec2e9b7af9e41eb1336ff828e4a6263fb9 100644
--- a/chrome/browser/extensions/webstore_install_result.h
+++ b/chrome/common/extensions/webstore_install_result.h
@@ -2,20 +2,23 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_RESULT_H_
-#define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_RESULT_H_
+#ifndef CHROME_COMMON_EXTENSIONS_WEBSTORE_INSTALL_RESULT_H_
+#define CHROME_COMMON_EXTENSIONS_WEBSTORE_INSTALL_RESULT_H_
namespace extensions {
namespace webstore_install {
// Result codes returned by WebstoreStandaloneInstaller and its subclasses.
+// IMPORTANT: Keep this list in sync with both the definition in
+// chrome/common/extensions/api/webstore.json and
+// chrome/common/extensions/api/webstore/webstore_install_constants.cc!
enum Result {
// Successful operation.
SUCCESS,
// Unknown error.
- UNKNOWN_ERROR,
+ OTHER_ERROR,
// The operation was aborted as the requestor is no longer alive.
ABORTED,
@@ -65,11 +68,15 @@ enum Result {
LAUNCH_UNSUPPORTED_EXTENSION_TYPE,
// A launch of the same extension is in progress.
- LAUNCH_IN_PROGRESS
+ LAUNCH_IN_PROGRESS,
+
+ // The final (and unused) result type for enum verification.
+ // New results should go above this entry, and this entry should be updated.
+ RESULT_LAST = LAUNCH_IN_PROGRESS,
};
} // namespace webstore_install
} // namespace extensions
-#endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALL_RESULT_H_
+#endif // CHROME_COMMON_EXTENSIONS_WEBSTORE_INSTALL_RESULT_H_

Powered by Google App Engine
This is Rietveld 408576698