Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3697)

Unified Diff: chrome/common/extensions/chrome_extension_messages.h

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/chrome_extension_messages.h
diff --git a/chrome/common/extensions/chrome_extension_messages.h b/chrome/common/extensions/chrome_extension_messages.h
index cd1b5cc11691effa6cf11006aaa23e3bf1339b18..42c915afb300723364377a0bedaad2f24374f97c 100644
--- a/chrome/common/extensions/chrome_extension_messages.h
+++ b/chrome/common/extensions/chrome_extension_messages.h
@@ -12,6 +12,7 @@
#include "base/strings/string16.h"
#include "chrome/common/extensions/api/webstore/webstore_api_constants.h"
+#include "chrome/common/extensions/webstore_install_result.h"
#include "chrome/common/web_application_info.h"
#include "extensions/common/stack_frame.h"
#include "ipc/ipc_message_macros.h"
@@ -21,6 +22,8 @@
IPC_ENUM_TRAITS_MAX_VALUE(extensions::api::webstore::InstallStage,
extensions::api::webstore::INSTALL_STAGE_INSTALLING)
+IPC_ENUM_TRAITS_MAX_VALUE(extensions::webstore_install::Result,
+ extensions::webstore_install::RESULT_LAST)
IPC_STRUCT_TRAITS_BEGIN(extensions::StackFrame)
IPC_STRUCT_TRAITS_MEMBER(line_number)
@@ -70,10 +73,11 @@ IPC_MESSAGE_ROUTED1(ExtensionMsg_InlineInstallDownloadProgress,
// Send to renderer once the installation mentioned on
// ExtensionHostMsg_InlineWebstoreInstall is complete.
-IPC_MESSAGE_ROUTED3(ExtensionMsg_InlineWebstoreInstallResponse,
+IPC_MESSAGE_ROUTED4(ExtensionMsg_InlineWebstoreInstallResponse,
int32 /* install id */,
bool /* whether the install was successful */,
- std::string /* error */)
+ std::string /* error */,
+ extensions::webstore_install::Result /* result */)
// Messages sent from the renderer to the browser.

Powered by Google App Engine
This is Rietveld 408576698