chrome/browser/extensions/webstore_inline_installer_unittest.cc - Issue 384823002: Introduce a stable set of errors for inline install

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_inline_installer_unittest.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_inline_installer_unittest.cc

diff --git a/chrome/browser/extensions/webstore_inline_installer_unittest.cc b/chrome/browser/extensions/webstore_inline_installer_unittest.cc

index f3fa393b2587610c1173cb6fd2dc529e2b4e39c8..493d3c9a787d7d383619177feb838ea9ae743be2 100644

--- a/chrome/browser/extensions/webstore_inline_installer_unittest.cc

+++ b/chrome/browser/extensions/webstore_inline_installer_unittest.cc

@@ -5,6 +5,7 @@

#include <vector>

#include "chrome/browser/extensions/webstore_inline_installer.h"

+#include "chrome/common/extensions/webstore_install_result.h"

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "content/public/browser/web_contents.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -30,7 +31,9 @@ class TestWebstoreInlineInstaller : public WebstoreInlineInstaller {

virtual ~TestWebstoreInlineInstaller();

};

-void TestInstallerCallback(bool success, const std::string& error) {}

+void TestInstallerCallback(bool success,

+ const std::string& error,

+ webstore_install::Result result) {}

TestWebstoreInlineInstaller::TestWebstoreInlineInstaller(

content::WebContents* contents,