Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2273)

Unified Diff: chrome/browser/extensions/startup_helper.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/startup_helper.cc
diff --git a/chrome/browser/extensions/startup_helper.cc b/chrome/browser/extensions/startup_helper.cc
index 4074b5f7c849ac6145256c68fb78777493b9e84e..1dac8806620b548059a840b24df15a91f6d85ec2 100644
--- a/chrome/browser/extensions/startup_helper.cc
+++ b/chrome/browser/extensions/startup_helper.cc
@@ -29,7 +29,7 @@ using content::BrowserThread;
namespace {
void PrintPackExtensionMessage(const std::string& message) {
- printf("%s\n", message.c_str());
+ VLOG(1) << message;
}
} // namespace
@@ -213,7 +213,9 @@ class AppInstallHelper {
private:
WebstoreStandaloneInstaller::Callback Callback();
- void OnAppInstallComplete(bool success, const std::string& error);
+ void OnAppInstallComplete(bool success,
+ const std::string& error,
+ webstore_install::Result result);
DoneCallback done_callback_;
@@ -252,7 +254,8 @@ void AppInstallHelper::BeginInstall(
}
void AppInstallHelper::OnAppInstallComplete(bool success,
- const std::string& error) {
+ const std::string& error,
+ webstore_install::Result result) {
success_ = success;
error_= error;
done_callback_.Run();

Powered by Google App Engine
This is Rietveld 408576698