Issue 384763002: Content is cropped and shifts to the left in RTL iFrames with scrollbars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384763002: Content is cropped and shifts to the left in RTL iFrames with scrollbars (Closed)

Created:
6 years, 5 months ago by tonikitoo_

Modified:
6 years, 5 months ago

Reviewers:
tonikitoo_

CC:
blink-reviews, Julien - ping for review, PhistucKAtChromium, bokan

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Content is cropped and shifts to the left in RTL iFrames with scrollbars Patch revert "Place inner frame scrollbars on the left side, if indicated by the frame-level" or r169180 [1], that has caused layout problems on overflown RTL contents. Patch marks the existing affected tests as NeedsManualRebaseline in order to get results for all platforms from the bots, and perform rebaselines accordingly. Once this is done, idea is to re-mark them as flaky. [1] https://codereview.chromium.org/150733002 TBR=a1.gomes@sisa.samsung.com BUG=353111 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177872

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -29 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	Source/core/frame/FrameView.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	1 chunk	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tonikitoo_

If bots run fine, I will go ahead with landing the revert to trunk.

6 years, 5 months ago (2014-07-10 14:22:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a1.gomes@sisa.samsung.com/384763002/1

6 years, 5 months ago (2014-07-10 18:30:33 UTC) #3

Message was sent while issue was closed.

Change committed as 177872

Expand Messages | Collapse Messages