Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 384763002: Content is cropped and shifts to the left in RTL iFrames with scrollbars (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1279 matching lines...) Expand 10 before | Expand all | Expand 10 after
1290 } 1290 }
1291 if (heightChanged) { 1291 if (heightChanged) {
1292 if (style->height().isFixed() && (style->top().isAuto() || style->bo ttom().isAuto())) 1292 if (style->height().isFixed() && (style->top().isAuto() || style->bo ttom().isAuto()))
1293 renderer->setNeedsPositionedMovementLayout(); 1293 renderer->setNeedsPositionedMovementLayout();
1294 else 1294 else
1295 renderer->setNeedsLayoutAndFullPaintInvalidation(); 1295 renderer->setNeedsLayoutAndFullPaintInvalidation();
1296 } 1296 }
1297 } 1297 }
1298 } 1298 }
1299 1299
1300 bool FrameView::shouldPlaceVerticalScrollbarOnLeft() const
1301 {
1302 // FIXME: Mainframe scrollbar placement should respect the embedding applica tion RTL UI policy.
1303 // See crbug.com/249860.
1304 if (m_frame->isMainFrame())
1305 return false;
1306
1307 Document* document = m_frame->document();
1308 if (!document)
1309 return false;
1310
1311 // <body> inherits 'direction' from <html>, so it can safaly be used
1312 // to dictate the frame vertical scrollbar placement.
1313 if (!document->body() || !document->body()->renderer())
1314 return false;
1315
1316 return document->body()->renderer()->style()->shouldPlaceBlockDirectionScrol lbarOnLogicalLeft();
1317 }
1318
1319 IntSize FrameView::scrollOffsetForFixedPosition() const 1300 IntSize FrameView::scrollOffsetForFixedPosition() const
1320 { 1301 {
1321 return toIntSize(clampScrollPosition(scrollPosition())); 1302 return toIntSize(clampScrollPosition(scrollPosition()));
1322 } 1303 }
1323 1304
1324 IntPoint FrameView::lastKnownMousePosition() const 1305 IntPoint FrameView::lastKnownMousePosition() const
1325 { 1306 {
1326 return m_frame->eventHandler().lastKnownMousePosition(); 1307 return m_frame->eventHandler().lastKnownMousePosition();
1327 } 1308 }
1328 1309
(...skipping 1947 matching lines...) Expand 10 before | Expand all | Expand 10 after
3276 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3257 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3277 { 3258 {
3278 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3259 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3279 if (AXObjectCache* cache = axObjectCache()) { 3260 if (AXObjectCache* cache = axObjectCache()) {
3280 cache->remove(scrollbar); 3261 cache->remove(scrollbar);
3281 cache->handleScrollbarUpdate(this); 3262 cache->handleScrollbarUpdate(this);
3282 } 3263 }
3283 } 3264 }
3284 3265
3285 } // namespace WebCore 3266 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698