Issue 3847006: If default search is managed, we should not asked the user to choose it at Fi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3847006: If default search is managed, we should not asked the user to choose it at Fi... (Closed)

Created:
10 years, 2 months ago by jeanluc1

Modified:
9 years, 6 months ago

Reviewers:
tyoshino (SeeGerritForStatus)

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

If default search is managed, we should not asked the user to choose it at First Run. Make sure the minimum bubble is not showed if there is no default search. This is a re-issue of CL 3565013 without the extraneous change to search_engine_list_model.mm, to be done in a forthcoming CL> BUG=49306 TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63024

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+95 lines, -49 lines)			Patch
M	chrome/browser/browser_main.cc	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/first_run/first_run.cc	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/first_run/first_run_mac.mm	View	3 chunks	+15 lines, -3 lines	0 comments	Download
M	chrome/browser/first_run/first_run_win.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/first_run_dialog.h	View	3 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/first_run_dialog.cc	View	6 chunks	+37 lines, -15 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_model.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_model_unittest.cc	View	6 chunks	+8 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages