If default search is managed, we should not asked the user to choose it at Fi...

chrome/browser/gtk/first_run_dialog.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/first_run_dialog.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/i18n/rtl.h"
 #include "base/message_loop.h"
@@ skipping 68 matching lines @@
   gtk_container_child_set_property(GTK_CONTAINER(container),
                                    label, "y", &value);
   g_value_unset(&value);
 }
 
 }  // namespace
 
 // static
 bool FirstRunDialog::Show(Profile* profile,
                           bool randomize_search_engine_order) {
+  // Figure out which dialogs we will show.
+  // If the default search is managed via policy, we won't ask.
+  const TemplateURLModel* search_engines_model = profile->GetTemplateURLModel();
+  bool show_search_engines_dialog = search_engines_model &&
+      !search_engines_model->is_default_search_managed();
+
+#if defined(GOOGLE_CHROME_BUILD)
+  // If the metrics reporting is managed, we won't ask.
+  const PrefService::Preference* metrics_reporting_pref =
+      g_browser_process->local_state()->FindPreference(
+          prefs::kMetricsReportingEnabled);
+  bool show_reporting_dialog = !metrics_reporting_pref ||
+      !metrics_reporting_pref->IsManaged();
+#else
+  bool show_reporting_dialog = false;
+#endif
+
+  if (!show_search_engines_dialog && !show_reporting_dialog)
+    return true;  // Nothing to do
+
   int response = -1;
   // Object deletes itself.
-  new FirstRunDialog(profile, randomize_search_engine_order, response);
+  new FirstRunDialog(profile,
+                     show_reporting_dialog,
+                     show_search_engines_dialog,
+                     &response);
 
   // TODO(port): it should be sufficient to just run the dialog:
   // int response = gtk_dialog_run(GTK_DIALOG(dialog));
   // but that spins a nested message loop and hoses us.  :(
   // http://code.google.com/p/chromium/issues/detail?id=12552
   // Instead, run a loop and extract the response manually.
   MessageLoop::current()->Run();
 
   return (response == GTK_RESPONSE_ACCEPT);
 }
 
 FirstRunDialog::FirstRunDialog(Profile* profile,
-                               bool randomize_search_engine_order,
-                               int& response)
+                               bool show_reporting_dialog,
+                               bool show_search_engines_dialog,
+                               int* response)
     : search_engine_window_(NULL),
       dialog_(NULL),
       report_crashes_(NULL),
       make_default_(NULL),
       profile_(profile),
       chosen_search_engine_(NULL),
+      show_reporting_dialog_(show_reporting_dialog),
       response_(response) {
+  if (!show_search_engines_dialog) {
+    ShowReportingDialog();
+    return;
+  }
   search_engines_model_ = profile_->GetTemplateURLModel();
+
   ShowSearchEngineWindow();
 
   search_engines_model_->AddObserver(this);
   if (search_engines_model_->loaded())
     OnTemplateURLModelChanged();
   else
     search_engines_model_->Load();
 }
 
 FirstRunDialog::~FirstRunDialog() {
@@ skipping 60 matching lines @@
   gtk_box_pack_start(GTK_BOX(bubble_area_box), search_engine_hbox_,
                      FALSE, FALSE, 0);
 
   gtk_box_pack_start(GTK_BOX(content_area), bubble_area_background,
                      TRUE, TRUE, 0);
 
   gtk_widget_show_all(content_area);
   gtk_window_present(GTK_WINDOW(search_engine_window_));
 }
 
-void FirstRunDialog::ShowDialog() {
+void FirstRunDialog::ShowReportingDialog() {
   // The purpose of the dialog is to ask the user to enable stats and crash
   // reporting. This setting may be controlled through configuration management
   // in enterprise scenarios. If that is the case, skip the dialog entirely,
   // it's not worth bothering the user for only the default browser question
   // (which is likely to be forced in enterprise deployments anyway).
-  const PrefService::Preference* metrics_reporting_pref =
-      g_browser_process->local_state()->FindPreference(
-          prefs::kMetricsReportingEnabled);
-  if (metrics_reporting_pref && metrics_reporting_pref->IsManaged()) {
+  if (!show_reporting_dialog_) {
     OnResponseDialog(NULL, GTK_RESPONSE_ACCEPT);
     return;
   }
 
-#if defined(GOOGLE_CHROME_BUILD)
   dialog_ = gtk_dialog_new_with_buttons(
       l10n_util::GetStringUTF8(IDS_FIRSTRUN_DLG_TITLE).c_str(),
       NULL,  // No parent
       (GtkDialogFlags) (GTK_DIALOG_MODAL | GTK_DIALOG_NO_SEPARATOR),
       NULL);
   gtk_util::AddButtonToDialog(dialog_,
       l10n_util::GetStringUTF8(IDS_FIRSTRUN_DLG_OK).c_str(),
       GTK_STOCK_APPLY, GTK_RESPONSE_ACCEPT);
   gtk_window_set_deletable(GTK_WINDOW(dialog_), FALSE);
 
@@ skipping 25 matching lines @@
                      gtk_util::IndentWidget(learn_more_link),
                      FALSE, FALSE, 0);
   g_signal_connect(learn_more_link, "clicked",
                    G_CALLBACK(OnLearnMoreLinkClickedThunk), this);
 
   gtk_box_pack_start(GTK_BOX(content_area), learn_more_vbox, FALSE, FALSE, 0);
 
   g_signal_connect(dialog_, "response",
                    G_CALLBACK(OnResponseDialogThunk), this);
   gtk_widget_show_all(dialog_);
-#else  // !defined(GOOGLE_CHROME_BUILD)
-  // We don't show the dialog in chromium. Pretend the user accepted.
-  OnResponseDialog(NULL, GTK_RESPONSE_ACCEPT);
-#endif  // !defined(GOOGLE_CHROME_BUILD)
 }
 
 void FirstRunDialog::OnTemplateURLModelChanged() {
   // We only watch the search engine model change once, on load.  Remove
   // observer so we don't try to redraw if engines change under us.
   search_engines_model_->RemoveObserver(this);
 
   // Add search engines in |search_engines_model_| to buttons list.
   std::vector<const TemplateURL*> ballot_engines =
       search_engines_model_->GetTemplateURLs();
@@ skipping 73 matching lines @@
 void FirstRunDialog::OnSearchEngineButtonClicked(GtkWidget* sender) {
   chosen_search_engine_ = static_cast<TemplateURL*>(
       g_object_get_data(G_OBJECT(sender), kSearchEngineKey));
   gtk_widget_destroy(search_engine_window_);
 }
 
 void FirstRunDialog::OnSearchEngineWindowDestroy(GtkWidget* sender) {
   search_engine_window_ = NULL;
   if (chosen_search_engine_) {
     search_engines_model_->SetDefaultSearchProvider(chosen_search_engine_);
-    ShowDialog();
+    ShowReportingDialog();
   } else {
     FirstRunDone();
   }
 }
 
 void FirstRunDialog::OnResponseDialog(GtkWidget* widget, int response) {
   if (dialog_)
     gtk_widget_hide_all(dialog_);
-  response_ = response;
+  *response_ = response;
 
   // Mark that first run has ran.
   FirstRun::CreateSentinel();
 
   // Check if user has opted into reporting.
   if (report_crashes_ &&
       gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(report_crashes_))) {
 #if defined(USE_LINUX_BREAKPAD)
     if (GoogleUpdateSettings::SetCollectStatsConsent(true))
       InitCrashReporter();
@@ skipping 17 matching lines @@
 }
 
 void FirstRunDialog::FirstRunDone() {
   FirstRun::SetShowWelcomePagePref();
 
   if (dialog_)
     gtk_widget_destroy(dialog_);
   MessageLoop::current()->Quit();
   delete this;
 }