Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: Source/modules/serviceworkers/FetchResponseData.h

Issue 384633002: Oilpan: add transition types to remaining Fetch and ServiceWorker objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/FetchResponseData.h
diff --git a/Source/modules/serviceworkers/FetchResponseData.h b/Source/modules/serviceworkers/FetchResponseData.h
index 5aa588a95f90247d289b66c1d1a61e1af1b56e7c..00f585e24d0a06f347aa1c8d44ec5e889ce0bf5d 100644
--- a/Source/modules/serviceworkers/FetchResponseData.h
+++ b/Source/modules/serviceworkers/FetchResponseData.h
@@ -5,6 +5,7 @@
#ifndef FetchResponseData_h
#define FetchResponseData_h
+#include "platform/heap/Handle.h"
#include "platform/weborigin/KURL.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
@@ -17,7 +18,7 @@ namespace WebCore {
class BlobDataHandle;
class FetchHeaderList;
-class FetchResponseData : public RefCounted<FetchResponseData> {
+class FetchResponseData FINAL : public RefCountedWillBeGarbageCollectedFinalized<FetchResponseData> {
WTF_MAKE_NONCOPYABLE(FetchResponseData);
public:
// "A response has an associated type which is one of basic, CORS, default,
@@ -27,12 +28,12 @@ public:
// end-user abort, fatal, and timeout."
enum TerminationReason { EndUserAbortTermination, FatalTermination, TimeoutTermination };
- static PassRefPtr<FetchResponseData> create();
- static PassRefPtr<FetchResponseData> createNetworkErrorResponse();
+ static PassRefPtrWillBeRawPtr<FetchResponseData> create();
+ static PassRefPtrWillBeRawPtr<FetchResponseData> createNetworkErrorResponse();
- PassRefPtr<FetchResponseData> createBasicFilteredResponse();
- PassRefPtr<FetchResponseData> createCORSFilteredResponse();
- PassRefPtr<FetchResponseData> createOpaqueFilteredResponse();
+ PassRefPtrWillBeRawPtr<FetchResponseData> createBasicFilteredResponse();
+ PassRefPtrWillBeRawPtr<FetchResponseData> createCORSFilteredResponse();
+ PassRefPtrWillBeRawPtr<FetchResponseData> createOpaqueFilteredResponse();
Type type() const { return m_type; }
const KURL& url() const { return m_url; }
@@ -48,6 +49,8 @@ public:
void populateWebServiceWorkerResponse(blink::WebServiceWorkerResponse&);
+ void trace(Visitor*);
+
private:
FetchResponseData(Type, unsigned short, AtomicString);
@@ -56,9 +59,9 @@ private:
KURL m_url;
unsigned short m_status;
AtomicString m_statusMessage;
- RefPtr<FetchHeaderList> m_headerList;
+ RefPtrWillBeMember<FetchHeaderList> m_headerList;
RefPtr<BlobDataHandle> m_blobDataHandle;
- RefPtr<FetchResponseData> m_internalResponse;
+ RefPtrWillBeMember<FetchResponseData> m_internalResponse;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698