Chromium Code Reviews| Index: Source/modules/serviceworkers/Response.h |
| diff --git a/Source/modules/serviceworkers/Response.h b/Source/modules/serviceworkers/Response.h |
| index ba41b63718f3c3c587f267cd33d58e1c4cac4588..4ccba10fb0660cb398dd701ca530b7f09276376d 100644 |
| --- a/Source/modules/serviceworkers/Response.h |
| +++ b/Source/modules/serviceworkers/Response.h |
| @@ -10,6 +10,7 @@ |
| #include "modules/serviceworkers/FetchResponseData.h" |
| #include "modules/serviceworkers/Headers.h" |
| #include "platform/blob/BlobData.h" |
| +#include "platform/heap/Handle.h" |
| #include "wtf/RefCounted.h" |
| #include "wtf/RefPtr.h" |
| #include "wtf/text/WTFString.h" |
| @@ -20,30 +21,32 @@ namespace WebCore { |
| class Blob; |
| class ExceptionState; |
| -struct ResponseInit; |
| +class ResponseInit; |
| -class Response FINAL : public RefCounted<Response>, public ScriptWrappable { |
| +class Response FINAL : public RefCountedWillBeGarbageCollectedFinalized<Response>, public ScriptWrappable { |
|
haraken
2014/07/11 05:39:12
Can we remove the destructor from Response and mak
sof
2014/07/11 06:11:20
Yes, that is possible. Done.
(It wasn't possible
|
| public: |
| - static PassRefPtr<Response> create(Blob*, const Dictionary&, ExceptionState&); |
| - static PassRefPtr<Response> create(Blob*, const ResponseInit&, ExceptionState&); |
| + static PassRefPtrWillBeRawPtr<Response> create(Blob*, const Dictionary&, ExceptionState&); |
| + static PassRefPtrWillBeRawPtr<Response> create(Blob*, const ResponseInit&, ExceptionState&); |
| - static PassRefPtr<Response> create(PassRefPtr<FetchResponseData>); |
| + static PassRefPtrWillBeRawPtr<Response> create(PassRefPtrWillBeRawPtr<FetchResponseData>); |
| ~Response() { }; |
| String type() const; |
| String url() const; |
| unsigned short status() const; |
| String statusText() const; |
| - PassRefPtr<Headers> headers() const; |
| + PassRefPtrWillBeRawPtr<Headers> headers() const; |
| void populateWebServiceWorkerResponse(blink::WebServiceWorkerResponse&); |
| + void trace(Visitor*); |
| + |
| private: |
| Response(); |
| - Response(PassRefPtr<FetchResponseData>); |
| + explicit Response(PassRefPtrWillBeRawPtr<FetchResponseData>); |
| - RefPtr<FetchResponseData> m_response; |
| - RefPtr<Headers> m_headers; |
| + RefPtrWillBeMember<FetchResponseData> m_response; |
| + RefPtrWillBeMember<Headers> m_headers; |
| // FIXME: Support FetchBodyStream. |
| }; |