Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: Source/modules/serviceworkers/FetchEvent.h

Issue 384633002: Oilpan: add transition types to remaining Fetch and ServiceWorker objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/FetchEvent.h
diff --git a/Source/modules/serviceworkers/FetchEvent.h b/Source/modules/serviceworkers/FetchEvent.h
index 3dc8b3fb826b1f02c986847a00db5d0b581fcc3e..2613703979c8943e71389c049bff291a2138b9ff 100644
--- a/Source/modules/serviceworkers/FetchEvent.h
+++ b/Source/modules/serviceworkers/FetchEvent.h
@@ -21,10 +21,10 @@ class RespondWithObserver;
class FetchEvent FINAL : public Event {
public:
static PassRefPtrWillBeRawPtr<FetchEvent> create();
- static PassRefPtrWillBeRawPtr<FetchEvent> create(PassRefPtr<RespondWithObserver>, PassRefPtr<Request>);
+ static PassRefPtrWillBeRawPtr<FetchEvent> create(PassRefPtr<RespondWithObserver>, PassRefPtrWillBeRawPtr<Request>);
virtual ~FetchEvent() { }
- PassRefPtr<Request> request() const;
+ PassRefPtrWillBeRawPtr<Request> request() const;
bool isReload() const;
void respondWith(ScriptState*, const ScriptValue&);
@@ -37,11 +37,11 @@ public:
protected:
FetchEvent();
- FetchEvent(PassRefPtr<RespondWithObserver>, PassRefPtr<Request>);
+ FetchEvent(PassRefPtr<RespondWithObserver>, PassRefPtrWillBeRawPtr<Request>);
private:
RefPtr<RespondWithObserver> m_observer;
haraken 2014/07/11 05:39:11 You can consider moving RespondWithObserver in a f
sof 2014/07/11 06:11:20 It looks feasible to move the ContextLifecycleObse
- RefPtr<Request> m_request;
+ RefPtrWillBeMember<Request> m_request;
bool m_isReload;
};

Powered by Google App Engine
This is Rietveld 408576698