Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 38453002: Move members of HTMLPlugInImageElement to HTMLPlugInElement, part 4. (Closed)

Created:
7 years, 2 months ago by tkent
Modified:
7 years, 2 months ago
Reviewers:
Hajime Morrita, hayato
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Move members of HTMLPlugInImageElement to HTMLPlugInElement, part 4. This CL moves the following member functions: - allowedToLoadFrameURL() - wouldLoadAsNetscapePlugin() - createRenderer() - willRecalcStyle() - finishParsingChildren() Note: We should move setHasCustomStyleCallbacks() call in the constructor for willRecalcStyle(). Also, this CL remove member functions without implementations, swapRendererTimerFired() and restartSimilarPlugIns(). This is a part of a task to merge HTMLPlugInImageELement into HTMLPlugInElement. Only HTMLPlugInImageElement inherits from HTMLPlugInElement. BUG=309978 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -79 lines) Patch
M Source/core/html/HTMLPlugInElement.h View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 4 chunks +59 lines, -0 lines 0 comments Download
M Source/core/html/HTMLPlugInImageElement.h View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/html/HTMLPlugInImageElement.cpp View 2 chunks +0 lines, -66 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
7 years, 2 months ago (2013-10-23 23:21:13 UTC) #1
Hajime Morrita
lgtm. It might be nice to have R= line in the CL description so that ...
7 years, 2 months ago (2013-10-24 01:09:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/38453002/1
7 years, 2 months ago (2013-10-24 01:17:45 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-24 01:22:33 UTC) #4
Message was sent while issue was closed.
Change committed as 160401

Powered by Google App Engine
This is Rietveld 408576698