Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: Source/core/html/HTMLPlugInElement.cpp

Issue 38453002: Move members of HTMLPlugInImageElement to HTMLPlugInElement, part 4. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLPlugInElement.h ('k') | Source/core/html/HTMLPlugInImageElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLPlugInElement.cpp
diff --git a/Source/core/html/HTMLPlugInElement.cpp b/Source/core/html/HTMLPlugInElement.cpp
index d22bb9eff024cd6edc132a6acbb37b693295d28e..5df9aac5657c9df2180d13b58e7ae3179f6d57d3 100644
--- a/Source/core/html/HTMLPlugInElement.cpp
+++ b/Source/core/html/HTMLPlugInElement.cpp
@@ -37,6 +37,7 @@
#include "core/platform/MIMETypeFromURL.h"
#include "core/plugins/PluginView.h"
#include "core/rendering/RenderEmbeddedObject.h"
+#include "core/rendering/RenderImage.h"
#include "core/rendering/RenderWidget.h"
#include "platform/Widget.h"
#include "wtf/UnusedParam.h"
@@ -59,6 +60,7 @@ HTMLPlugInElement::HTMLPlugInElement(const QualifiedName& tagName, Document& doc
, m_shouldPreferPlugInsForImages(preferPlugInsForImagesOption == ShouldPreferPlugInsForImages)
, m_displayState(Playing)
{
+ setHasCustomStyleCallbacks();
}
HTMLPlugInElement::~HTMLPlugInElement()
@@ -165,6 +167,41 @@ void HTMLPlugInElement::detach(const AttachContext& context)
HTMLFrameOwnerElement::detach(context);
}
+RenderObject* HTMLPlugInElement::createRenderer(RenderStyle* style)
+{
+ // Fallback content breaks the DOM->Renderer class relationship of this
+ // class and all superclasses because createObject won't necessarily
+ // return a RenderEmbeddedObject, RenderPart or even RenderWidget.
+ if (useFallbackContent())
+ return RenderObject::createObject(this, style);
+
+ if (isImageType()) {
+ RenderImage* image = new RenderImage(this);
+ image->setImageResource(RenderImageResource::create());
+ return image;
+ }
+
+ return new RenderEmbeddedObject(this);
+}
+
+void HTMLPlugInElement::willRecalcStyle(StyleRecalcChange)
+{
+ // FIXME: Why is this necessary? Manual re-attach is almost always wrong.
+ if (!useFallbackContent() && needsWidgetUpdate() && renderer() && !isImageType())
+ reattach();
+}
+
+void HTMLPlugInElement::finishParsingChildren()
+{
+ HTMLFrameOwnerElement::finishParsingChildren();
+ if (useFallbackContent())
+ return;
+
+ setNeedsWidgetUpdate(true);
+ if (inDocument())
+ setNeedsStyleRecalc();
+}
+
void HTMLPlugInElement::resetInstance()
{
m_pluginWrapper.clear();
@@ -337,4 +374,26 @@ RenderEmbeddedObject* HTMLPlugInElement::renderEmbeddedObject() const
return toRenderEmbeddedObject(renderer());
}
+// We don't use m_url, as it may not be the final URL that the object loads,
+// depending on <param> values.
+bool HTMLPlugInElement::allowedToLoadFrameURL(const String& url)
+{
+ KURL completeURL = document().completeURL(url);
+ if (contentFrame() && protocolIsJavaScript(completeURL)
+ && !document().securityOrigin()->canAccess(contentDocument()->securityOrigin()))
+ return false;
+ return document().frame()->isURLAllowed(completeURL);
+}
+
+// We don't use m_url, or m_serviceType as they may not be the final values
+// that <object> uses depending on <param> values.
+bool HTMLPlugInElement::wouldLoadAsNetscapePlugin(const String& url, const String& serviceType)
+{
+ ASSERT(document().frame());
+ KURL completedURL;
+ if (!url.isEmpty())
+ completedURL = document().completeURL(url);
+ return document().frame()->loader().client()->objectContentType(completedURL, serviceType, shouldPreferPlugInsForImages()) == ObjectContentNetscapePlugin;
+}
+
}
« no previous file with comments | « Source/core/html/HTMLPlugInElement.h ('k') | Source/core/html/HTMLPlugInImageElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698