Remove RequestAnimationFrame from mojo, add delayed tasks to RunLoop

Remove RequestAnimationFrame from mojo, add delayed tasks to RunLoop

Having a RequestAnimationFrame API on CommandBuffer makes no sense - the
context itself has nothing to do with scheduling and may not even be
swapping onscreen.  The spinning cube app was using this API as a way to
get delayed tasks without depending on base - basically
posttask-via-mojo-message. This adds basic delayed task support to the
public RunLoop and uses that instead. This only supports posting tasks
from the thread that owns the runloop. We can expand as needed. The mojo
RunLoop attempts to interleave delayed tasks with handle handlers, like
base's MessageLoop.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285560

[piman, 2014-07-25 01:09:57]

Thank you. LGTM!

[darin (slow to review), 2014-07-25 02:46:06]

LGTM

[darin (slow to review), 2014-07-25 02:47:50]

https://codereview.chromium.org/384513003/diff/40001/mojo/examples/sample_app...
File mojo/examples/sample_app/gles2_client_impl.cc (right):

https://codereview.chromium.org/384513003/diff/40001/mojo/examples/sample_app...
mojo/examples/sample_app/gles2_client_impl.cc:117:
mojo::RunLoop::current()->PostDelayedTask(mojo::Closure(DrawRunnable(this)),
actually, what ensures that |this| remains valid when the closure is run?

[jamesr, 2014-07-25 02:48:12]

The CQ bit was checked by jamesr@chromium.org

[jamesr, 2014-07-25 02:48:14]

The CQ bit was unchecked by jamesr@chromium.org

[jamesr, 2014-07-25 02:51:31]

On 2014/07/25 02:47:50, darin wrote:
>
https://codereview.chromium.org/384513003/diff/40001/mojo/examples/sample_app...
> File mojo/examples/sample_app/gles2_client_impl.cc (right):
> 
>
https://codereview.chromium.org/384513003/diff/40001/mojo/examples/sample_app...
> mojo/examples/sample_app/gles2_client_impl.cc:117:
> mojo::RunLoop::current()->PostDelayedTask(mojo::Closure(DrawRunnable(this)),
> actually, what ensures that |this| remains valid when the closure is run?

|this| is tied to the lifetime of the app and we should shut down the RunLoop
before destroying the app. I'd like to use C++'s weak_ptr for this in the mojo
public API to generally solve this but we aren't quite there toolchain wise. For
now, we just have to be really careful.

[jamesr, 2014-07-25 02:52:20]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-25 02:53:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/384513003/40001

[commit-bot: I haz the power, 2014-07-25 09:24:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-25 10:52:27]

Change committed as 285560