Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 384483002: Add IDs to Telemetry Pages. (Closed)

Created:
6 years, 5 months ago by eakuefner
Modified:
6 years, 5 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add IDs to Telemetry Pages. For outputting Telemtry results as JSON, we will want to be able to refer to a Page by an ID that uniquely identifies it within a page set. This CL puts that machinery in place. R=nduca, dtu BUG=375541 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282178

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address Nat's comments #

Patch Set 3 : Get rid of unused classmethod #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/telemetry/telemetry/page/page.py View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
eakuefner
6 years, 5 months ago (2014-07-09 18:51:30 UTC) #1
eakuefner
6 years, 5 months ago (2014-07-09 18:53:47 UTC) #2
nduca
Please use a global as i had shown in my notes, not a classmember. It ...
6 years, 5 months ago (2014-07-09 18:57:36 UTC) #3
nduca
https://codereview.chromium.org/384483002/diff/1/tools/telemetry/telemetry/page/page.py File tools/telemetry/telemetry/page/page.py (right): https://codereview.chromium.org/384483002/diff/1/tools/telemetry/telemetry/page/page.py#newcode71 tools/telemetry/telemetry/page/page.py:71: def page_id(self): also why page_id and not just id?
6 years, 5 months ago (2014-07-09 18:58:00 UTC) #4
nduca
https://codereview.chromium.org/384483002/diff/1/tools/telemetry/telemetry/page/page.py File tools/telemetry/telemetry/page/page.py (right): https://codereview.chromium.org/384483002/diff/1/tools/telemetry/telemetry/page/page.py#newcode10 tools/telemetry/telemetry/page/page.py:10: _next_page_id = 0 https://codereview.chromium.org/384483002/diff/1/tools/telemetry/telemetry/page/page.py#newcode24 tools/telemetry/telemetry/page/page.py:24: self._id = self._new_id() global ...
6 years, 5 months ago (2014-07-09 19:03:06 UTC) #5
eakuefner
https://codereview.chromium.org/384483002/diff/1/tools/telemetry/telemetry/page/page.py File tools/telemetry/telemetry/page/page.py (right): https://codereview.chromium.org/384483002/diff/1/tools/telemetry/telemetry/page/page.py#newcode10 tools/telemetry/telemetry/page/page.py:10: On 2014/07/09 19:03:06, nduca wrote: > _next_page_id = 0 ...
6 years, 5 months ago (2014-07-09 19:27:33 UTC) #6
nduca
lgtm
6 years, 5 months ago (2014-07-09 19:34:01 UTC) #7
eakuefner
The CQ bit was checked by eakuefner@chromium.org
6 years, 5 months ago (2014-07-09 19:35:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eakuefner@chromium.org/384483002/40001
6 years, 5 months ago (2014-07-09 19:37:27 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 23:59:02 UTC) #10
Message was sent while issue was closed. 
Change committed as 282178

Powered by Google App Engine
This is Rietveld 408576698