Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: tools/telemetry/telemetry/page/page.py

Issue 384483002: Add IDs to Telemetry Pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Get rid of unused classmethod Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page.py
diff --git a/tools/telemetry/telemetry/page/page.py b/tools/telemetry/telemetry/page/page.py
index 5ebce2242f86fdac2f45a319dfcf2f6c3e617e56..33101a70ce6e996f115d058948effce4ac5dd859 100644
--- a/tools/telemetry/telemetry/page/page.py
+++ b/tools/telemetry/telemetry/page/page.py
@@ -7,8 +7,10 @@ import os
import re
import urlparse
+_next_page_id = 0
class Page(object):
+
def __init__(self, url, page_set=None, base_dir=None, name=''):
self._url = url
self._page_set = page_set
@@ -19,6 +21,10 @@ class Page(object):
self._base_dir = base_dir
self._name = name
+ global _next_page_id
+ self._id = _next_page_id
+ _next_page_id += 1
+
# These attributes can be set dynamically by the page.
self.synthetic_delays = dict()
self.startup_url = page_set.startup_url if page_set else ''
@@ -63,6 +69,10 @@ class Page(object):
def url(self):
return self._url
+ @property
+ def id(self):
+ return self._id
+
def GetSyntheticDelayCategories(self):
result = []
for delay, options in self.synthetic_delays.items():
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698