Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1547)

Issue 384423002: [Canceled] Extensions: Add install_flags parameter to ManagementPolicy::UserMayLoad (Closed)

Created:
6 years, 5 months ago by Marc Treib
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Extensions: Add install_flags parameter to ManagementPolicy::UserMayLoad. This is a prerequisite for https://codereview.chromium.org/353493002/. BUG=390520

Patch Set 1 #

Patch Set 2 : fix and rebase #

Patch Set 3 : cleanup #

Patch Set 4 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -39 lines) Patch
M chrome/browser/apps/ephemeral_app_launcher.cc View 1 2 7 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher_browsertest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_error_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_checker.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_checker.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/standard_management_policy_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/standard_management_policy_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/standard_management_policy_provider_unittest.cc View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_unittest.cc View 1 2 3 4 chunks +7 lines, -3 lines 0 comments Download
M extensions/browser/extension_prefs.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M extensions/browser/management_policy.h View 3 chunks +12 lines, -2 lines 0 comments Download
M extensions/browser/management_policy.cc View 3 chunks +24 lines, -8 lines 0 comments Download
M extensions/browser/management_policy_unittest.cc View 1 2 3 5 chunks +12 lines, -9 lines 0 comments Download
M extensions/browser/test_management_policy.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/test_management_policy.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Marc Treib
As discussed in the comments of https://codereview.chromium.org/353493002/. PTAL!
6 years, 5 months ago (2014-07-14 13:43:44 UTC) #1
not at google - send to devlin
I think I may have erred in my suggestion here :( I am very sorry. ...
6 years, 5 months ago (2014-07-15 16:21:25 UTC) #2
Marc Treib
6 years, 5 months ago (2014-07-16 08:10:25 UTC) #3
On 2014/07/15 16:21:25, kalman wrote:
> I think I may have erred in my suggestion here :( I am very sorry. I preferred
> the original patch. An even simpler implementation of all of this as per
> crbug.com/393982 would be to expose a GetExtensionSyncData method on
> ExtensionSyncService - make sure that knows to return the sync data for
pending
> extensions as well - then use that.
> 
> but that can be done in a cleanup.

Okay, no worries! :) I agree that the original approach via creation_flags is
the least evil atm.
I might have some spare cycles to help out with the cleanup, but I don't wanna
promise anything before we've finalized this quarter's OKRs.

Powered by Google App Engine
This is Rietveld 408576698