Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Side by Side Diff: chrome/browser/extensions/standard_management_policy_provider_unittest.cc

Issue 384423002: [Canceled] Extensions: Add install_flags parameter to ManagementPolicy::UserMayLoad (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_loop.h" 5 #include "base/message_loop/message_loop.h"
6 #include "base/strings/string_number_conversions.h" 6 #include "base/strings/string_number_conversions.h"
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/extensions/blacklist.h" 8 #include "chrome/browser/extensions/blacklist.h"
9 #include "chrome/browser/extensions/standard_management_policy_provider.h" 9 #include "chrome/browser/extensions/standard_management_policy_provider.h"
10 #include "chrome/browser/extensions/test_extension_prefs.h" 10 #include "chrome/browser/extensions/test_extension_prefs.h"
11 #include "content/public/test/test_browser_thread.h" 11 #include "content/public/test/test_browser_thread.h"
12 #include "extensions/browser/extension_prefs.h" 12 #include "extensions/browser/extension_prefs.h"
13 #include "extensions/browser/install_flag.h"
13 #include "extensions/common/manifest_constants.h" 14 #include "extensions/common/manifest_constants.h"
14 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
15 16
17 const int kInstallFlags = extensions::kInstallFlagNone;
18
16 namespace extensions { 19 namespace extensions {
17 20
18 class StandardManagementPolicyProviderTest : public testing::Test { 21 class StandardManagementPolicyProviderTest : public testing::Test {
19 public: 22 public:
20 StandardManagementPolicyProviderTest() 23 StandardManagementPolicyProviderTest()
21 : ui_thread_(content::BrowserThread::UI, &message_loop_), 24 : ui_thread_(content::BrowserThread::UI, &message_loop_),
22 file_thread_(content::BrowserThread::FILE, &message_loop_), 25 file_thread_(content::BrowserThread::FILE, &message_loop_),
23 prefs_(message_loop_.message_loop_proxy().get()), 26 prefs_(message_loop_.message_loop_proxy().get()),
24 provider_(prefs()) {} 27 provider_(prefs()) {}
25 28
(...skipping 23 matching lines...) Expand all
49 StandardManagementPolicyProvider provider_; 52 StandardManagementPolicyProvider provider_;
50 }; 53 };
51 54
52 // Tests the behavior of the ManagementPolicy provider methods for an 55 // Tests the behavior of the ManagementPolicy provider methods for an
53 // extension required by policy. 56 // extension required by policy.
54 TEST_F(StandardManagementPolicyProviderTest, RequiredExtension) { 57 TEST_F(StandardManagementPolicyProviderTest, RequiredExtension) {
55 scoped_refptr<const Extension> extension = 58 scoped_refptr<const Extension> extension =
56 CreateExtension(Manifest::EXTERNAL_POLICY_DOWNLOAD, true); 59 CreateExtension(Manifest::EXTERNAL_POLICY_DOWNLOAD, true);
57 60
58 base::string16 error16; 61 base::string16 error16;
59 EXPECT_TRUE(provider_.UserMayLoad(extension.get(), &error16)); 62 EXPECT_TRUE(provider_.UserMayLoad(extension.get(), kInstallFlags, &error16));
60 EXPECT_EQ(base::string16(), error16); 63 EXPECT_EQ(base::string16(), error16);
61 64
62 // We won't check the exact wording of the error, but it should say 65 // We won't check the exact wording of the error, but it should say
63 // something. 66 // something.
64 EXPECT_FALSE(provider_.UserMayModifySettings(extension.get(), &error16)); 67 EXPECT_FALSE(provider_.UserMayModifySettings(extension.get(), &error16));
65 EXPECT_NE(base::string16(), error16); 68 EXPECT_NE(base::string16(), error16);
66 EXPECT_TRUE(provider_.MustRemainEnabled(extension.get(), &error16)); 69 EXPECT_TRUE(provider_.MustRemainEnabled(extension.get(), &error16));
67 EXPECT_NE(base::string16(), error16); 70 EXPECT_NE(base::string16(), error16);
68 } 71 }
69 72
70 // Tests the behavior of the ManagementPolicy provider methods for an 73 // Tests the behavior of the ManagementPolicy provider methods for an
71 // extension required by policy. 74 // extension required by policy.
72 TEST_F(StandardManagementPolicyProviderTest, NotRequiredExtension) { 75 TEST_F(StandardManagementPolicyProviderTest, NotRequiredExtension) {
73 scoped_refptr<const Extension> extension = 76 scoped_refptr<const Extension> extension =
74 CreateExtension(Manifest::INTERNAL, false); 77 CreateExtension(Manifest::INTERNAL, false);
75 78
76 base::string16 error16; 79 base::string16 error16;
77 EXPECT_TRUE(provider_.UserMayLoad(extension.get(), &error16)); 80 EXPECT_TRUE(provider_.UserMayLoad(extension.get(), kInstallFlags, &error16));
78 EXPECT_EQ(base::string16(), error16); 81 EXPECT_EQ(base::string16(), error16);
79 EXPECT_TRUE(provider_.UserMayModifySettings(extension.get(), &error16)); 82 EXPECT_TRUE(provider_.UserMayModifySettings(extension.get(), &error16));
80 EXPECT_EQ(base::string16(), error16); 83 EXPECT_EQ(base::string16(), error16);
81 EXPECT_FALSE(provider_.MustRemainEnabled(extension.get(), &error16)); 84 EXPECT_FALSE(provider_.MustRemainEnabled(extension.get(), &error16));
82 EXPECT_EQ(base::string16(), error16); 85 EXPECT_EQ(base::string16(), error16);
83 } 86 }
84 87
85 } // namespace extensions 88 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/standard_management_policy_provider.cc ('k') | chrome/browser/extensions/unpacked_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698