Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 38423002: Make aura::clients take Window instead of RootWindow (Closed)

Created:
7 years, 2 months ago by Ben Goodger (Google)
Modified:
7 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+aura_chromium.org, ben+ash_chromium.org, sadrul, dcheng, tfarina, kalyank, ben+views_chromium.org, ben+corewm_chromium.org
Visibility:
Public.

Description

Make aura::clients take Window instead of RootWindow In preparation for hiding/changing RootWindow more... R=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230641

Patch Set 1 #

Patch Set 2 : linux_aura #

Patch Set 3 : chromeos #

Patch Set 4 : cros tests #

Patch Set 5 : cros activation client #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -123 lines) Patch
M ash/display/screen_position_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_position_controller.cc View 5 1 chunk +4 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 2 chunks +1 line, -6 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.h View 2 chunks +1 line, -2 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 5 3 chunks +3 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bubble_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/drag_window_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/event_client_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/client/activation_client.h View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/aura/client/activation_client.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/client/capture_client.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/aura/client/capture_client.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/client/capture_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/client/default_activation_client.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/aura/client/default_activation_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/aura/client/default_capture_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/client/default_capture_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/client/dispatcher_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/client/dispatcher_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/aura/client/drag_drop_client.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/aura/client/drag_drop_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/aura/client/event_client.h View 2 chunks +8 lines, -8 lines 0 comments Download
M ui/aura/client/event_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/aura/client/focus_client.h View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/aura/client/focus_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/client/screen_position_client.h View 3 chunks +5 lines, -9 lines 0 comments Download
M ui/aura/client/screen_position_client.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M ui/aura/client/tooltip_client.h View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/aura/client/tooltip_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/aura/client/user_action_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/client/user_action_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/views/corewm/capture_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/corewm/focus_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_capture_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 1 6 chunks +4 lines, -10 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.h View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
7 years, 2 months ago (2013-10-23 22:31:59 UTC) #1
sky
LGTM
7 years, 2 months ago (2013-10-23 22:38:55 UTC) #2
Ben Goodger (Google)
7 years, 2 months ago (2013-10-24 04:43:29 UTC) #3
Message was sent while issue was closed. 
Committed patchset #6 manually as r230641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698