Issue 384109: Revert 31869 - Ignore keyboard messages from enter key in renderer if they we...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384109: Revert 31869 - Ignore keyboard messages from enter key in renderer if they we... (Closed)

Created:
11 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
GeorgeY

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 31869 - Ignore keyboard messages from enter key in renderer if they were not initiated there. BUG=26755 TEST=Enter messages initiated in omnibox should not propagate to renderer Review URL: http://codereview.chromium.org/384101 TBR=georgey@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31877

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -30 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_win.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View		2 chunks	+1 line, -27 lines	0 comments	Download

Total messages: 2 (0 generated)

scherkus (not reviewing)

11 years, 1 month ago (2009-11-13 02:16:25 UTC) #2

Reverting for now as this change appeared to have cause interactive_ui_tests on
Linux to fail.