Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2530)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_win.cc

Issue 384109: Revert 31869 - Ignore keyboard messages from enter key in renderer if they we... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_win.cc
===================================================================
--- chrome/browser/renderer_host/render_widget_host_view_win.cc (revision 31876)
+++ chrome/browser/renderer_host/render_widget_host_view_win.cc (working copy)
@@ -216,7 +216,6 @@
: render_widget_host_(widget),
track_mouse_leave_(false),
ime_notification_(false),
- capture_enter_key_(false),
is_hidden_(false),
about_to_validate_and_paint_(false),
close_on_deactivate_(false),
@@ -1188,32 +1187,7 @@
}
}
- // Special processing for enter key: When user hits enter in omnibox
- // we change focus to render host after the navigation, so repeat WM_KEYDOWNs
- // and WM_KEYUP are going to render host, despite being initiated in other
- // window. This code filters out these messages.
- bool ignore_keyboard_event = false;
- if (wparam == VK_RETURN) {
- if (message == WM_KEYDOWN) {
- if (KF_REPEAT & HIWORD(lparam)) {
- // this is a repeated key
- if (!capture_enter_key_)
- ignore_keyboard_event = true;
- } else {
- capture_enter_key_ = true;
- }
- } else if (message == WM_KEYUP) {
- if (!capture_enter_key_)
- ignore_keyboard_event = true;
- capture_enter_key_ = false;
- } else {
- // Ignore all other keyboard events for the enter key if not captured.
- if (!capture_enter_key_)
- ignore_keyboard_event = true;
- }
- }
-
- if (render_widget_host_ && !ignore_keyboard_event) {
+ if (render_widget_host_) {
render_widget_host_->ForwardKeyboardEvent(
NativeWebKeyboardEvent(m_hWnd, message, wparam, lparam));
}
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698