Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 384007: Distinguish between old and new FTP LIST response parsers (Closed)

Created:
11 years, 1 month ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
eroman, wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Distinguish between old and new FTP LIST response parsers in FTP histograms. This should allow us to see how compatible the new parser is. TEST=none BUG=25520 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31591

Patch Set 1 #

Total comments: 1

Patch Set 2 : eroman's suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -18 lines) Patch
M net/ftp/ftp_directory_listing_parsers.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_server_type_histograms.h View 1 1 chunk +16 lines, -8 lines 0 comments Download
M webkit/glue/ftp_directory_listing_response_delegate.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Paweł Hajdan Jr.
I'm really curious what the results will be... I consider another approach to this: tracking ...
11 years, 1 month ago (2009-11-10 17:00:13 UTC) #1
Paweł Hajdan Jr.
Reviewers: wtc, eroman, Message: I'm really curious what the results will be... I consider another ...
11 years, 1 month ago (2009-11-10 17:00:36 UTC) #2
Paweł Hajdan Jr.
Reviewers: wtc, eroman, Message: I'm really curious what the results will be... I consider another ...
11 years, 1 month ago (2009-11-10 17:16:43 UTC) #3
eroman
lgtm http://codereview.chromium.org/384007/diff/1/3 File net/ftp/ftp_server_type_histograms.h (right): http://codereview.chromium.org/384007/diff/1/3#newcode35 Line 35: SERVER_NEW_LS = 9, // Server using /bin/ls ...
11 years, 1 month ago (2009-11-10 19:18:02 UTC) #4
eroman
lgtm http://codereview.chromium.org/384007/diff/1/3 File net/ftp/ftp_server_type_histograms.h (right): http://codereview.chromium.org/384007/diff/1/3#newcode35 Line 35: SERVER_NEW_LS = 9, // Server using /bin/ls ...
11 years, 1 month ago (2009-11-10 19:18:20 UTC) #5
eroman
lgtm http://codereview.chromium.org/384007/diff/1/3 File net/ftp/ftp_server_type_histograms.h (right): http://codereview.chromium.org/384007/diff/1/3#newcode35 Line 35: SERVER_NEW_LS = 9, // Server using /bin/ls ...
11 years, 1 month ago (2009-11-10 19:24:22 UTC) #6
Paweł Hajdan Jr.
Thanks for the suggestion. Patch updated.
11 years, 1 month ago (2009-11-10 19:47:53 UTC) #7
Paweł Hajdan Jr.
Thanks for the suggestion. Patch updated. http://codereview.chromium.org/384007
11 years, 1 month ago (2009-11-10 19:48:14 UTC) #8
eroman
lgtm
11 years, 1 month ago (2009-11-10 20:11:49 UTC) #9
eroman
11 years, 1 month ago (2009-11-10 20:12:08 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698