Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: webkit/glue/ftp_directory_listing_response_delegate.cc

Issue 384007: Distinguish between old and new FTP LIST response parsers (Closed)
Patch Set: eroman's suggestion Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/ftp/ftp_server_type_histograms.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/glue/ftp_directory_listing_response_delegate.h" 5 #include "webkit/glue/ftp_directory_listing_response_delegate.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/i18n/icu_string_conversions.h" 9 #include "base/i18n/icu_string_conversions.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 line_length--; 75 line_length--;
76 lines->push_back(buffer->substr(cut_pos, line_length)); 76 lines->push_back(buffer->substr(cut_pos, line_length));
77 cut_pos = i + 1; 77 cut_pos = i + 1;
78 } 78 }
79 buffer->erase(0, cut_pos); 79 buffer->erase(0, cut_pos);
80 } 80 }
81 81
82 void LogFtpServerType(char server_type) { 82 void LogFtpServerType(char server_type) {
83 switch (server_type) { 83 switch (server_type) {
84 case 'E': 84 case 'E':
85 net::UpdateFtpServerTypeHistograms(net::SERVER_EPLF); 85 net::UpdateFtpServerTypeHistograms(net::SERVER_MOZ_EPLF);
86 break; 86 break;
87 case 'V': 87 case 'V':
88 net::UpdateFtpServerTypeHistograms(net::SERVER_VMS); 88 net::UpdateFtpServerTypeHistograms(net::SERVER_MOZ_VMS);
89 break; 89 break;
90 case 'C': 90 case 'C':
91 net::UpdateFtpServerTypeHistograms(net::SERVER_CMS); 91 net::UpdateFtpServerTypeHistograms(net::SERVER_MOZ_CMS);
92 break; 92 break;
93 case 'W': 93 case 'W':
94 net::UpdateFtpServerTypeHistograms(net::SERVER_DOS); 94 net::UpdateFtpServerTypeHistograms(net::SERVER_MOZ_DOS);
95 break; 95 break;
96 case 'O': 96 case 'O':
97 net::UpdateFtpServerTypeHistograms(net::SERVER_OS2); 97 net::UpdateFtpServerTypeHistograms(net::SERVER_MOZ_OS2);
98 break; 98 break;
99 case 'U': 99 case 'U':
100 net::UpdateFtpServerTypeHistograms(net::SERVER_LSL); 100 net::UpdateFtpServerTypeHistograms(net::SERVER_MOZ_LSL);
101 break; 101 break;
102 case 'w': 102 case 'w':
103 net::UpdateFtpServerTypeHistograms(net::SERVER_W16); 103 net::UpdateFtpServerTypeHistograms(net::SERVER_MOZ_W16);
104 break; 104 break;
105 case 'D': 105 case 'D':
106 net::UpdateFtpServerTypeHistograms(net::SERVER_DLS); 106 net::UpdateFtpServerTypeHistograms(net::SERVER_MOZ_DLS);
107 break; 107 break;
108 default: 108 default:
109 net::UpdateFtpServerTypeHistograms(net::SERVER_UNKNOWN); 109 net::UpdateFtpServerTypeHistograms(net::SERVER_UNKNOWN);
110 break; 110 break;
111 } 111 }
112 } 112 }
113 113
114 } // namespace 114 } // namespace
115 115
116 namespace webkit_glue { 116 namespace webkit_glue {
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 299
300 void FtpDirectoryListingResponseDelegate::SendResponseBufferToClient() { 300 void FtpDirectoryListingResponseDelegate::SendResponseBufferToClient() {
301 if (!response_buffer_.empty()) { 301 if (!response_buffer_.empty()) {
302 client_->didReceiveData(loader_, response_buffer_.data(), 302 client_->didReceiveData(loader_, response_buffer_.data(),
303 response_buffer_.length()); 303 response_buffer_.length());
304 response_buffer_.clear(); 304 response_buffer_.clear();
305 } 305 }
306 } 306 }
307 307
308 } // namespace webkit_glue 308 } // namespace webkit_glue
OLDNEW
« no previous file with comments | « net/ftp/ftp_server_type_histograms.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698