Issue 3840001: Revert 61848 - [Mac] UI for clearing sync data on the server....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3840001: Revert 61848 - [Mac] UI for clearing sync data on the server.... (Closed)

Created:
10 years, 2 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), Elliot Glaysher, Raz Mathias

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 61848 - [Mac] UI for clearing sync data on the server. xib change: Nest current checkboxes inside tab, add needed elements to other tab. BUG=57876 TEST=as in bug 54349; functionality currently hidden behind flag Review URL: http://codereview.chromium.org/3590020 TBR=avi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62786

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+611 lines, -2522 lines)			Patch
M	chrome/app/nibs/ClearBrowsingData.xib	View	27 chunks	+558 lines, -2317 lines	0 comments	Download
M	chrome/browser/cocoa/clear_browsing_data_controller.h	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/cocoa/clear_browsing_data_controller.mm	View	10 chunks	+30 lines, -169 lines	0 comments	Download
MM	chrome/browser/views/clear_server_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/browser/views/clear_server_data.cc	View	2 chunks	+22 lines, -23 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

http://codereview.chromium.org/3840001/diff/1/5 File chrome/browser/views/clear_server_data.cc (left): http://codereview.chromium.org/3840001/diff/1/5#oldcode295 chrome/browser/views/clear_server_data.cc:295: sync_service_->GetClearServerDataState(); This was a reverse-merge conflict due to the ...

10 years, 2 months ago (2010-10-15 20:28:56 UTC) #2

Manual changes LGTM.

Expand Messages | Collapse Messages