[Mac] UI for clearing sync data on the server....

[Mac] UI for clearing sync data on the server.

xib change: Nest current checkboxes inside tab, add needed elements to other tab.

BUG=57876
TEST=as in bug 54349; functionality currently hidden behind flag


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61848

[Avi (use Gerrit), 2010-10-05 22:36:57]

pink: the gooey Mac stuff
raz: the sync stuff

[pink (ping after 24hrs), 2010-10-06 14:29:26]

LGTM with style nits.

http://codereview.chromium.org/3590020/diff/5001/6003
File chrome/browser/cocoa/clear_browsing_data_controller.mm (right):

http://codereview.chromium.org/3590020/diff/5001/6003#newcode359
chrome/browser/cocoa/clear_browsing_data_controller.mm:359: // We only want to
call Suceeded/FailedClearingServerData once, not every
Standard note about mento's dislike of "we" in comments.

http://codereview.chromium.org/3590020/diff/5001/6003#newcode372
chrome/browser/cocoa/clear_browsing_data_controller.mm:372: // Clearing buttons
on all tabs are disabled at this
don't indent an extra 4 spaces, these should only be 2space indents and line up
with the break;
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Loops_...

[Avi (use Gerrit), 2010-10-06 14:43:15]

http://codereview.chromium.org/3590020/diff/5001/6003
File chrome/browser/cocoa/clear_browsing_data_controller.mm (right):

http://codereview.chromium.org/3590020/diff/5001/6003#newcode359
chrome/browser/cocoa/clear_browsing_data_controller.mm:359: // We only want to
call Suceeded/FailedClearingServerData once, not every
On 2010/10/06 14:29:27, pink wrote:
> Standard note about mento's dislike of "we" in comments.

Oh, now it's you too? :( Comment swiped from clear_server_data.cc; adjusted in
both places.

http://codereview.chromium.org/3590020/diff/5001/6003#newcode372
chrome/browser/cocoa/clear_browsing_data_controller.mm:372: // Clearing buttons
on all tabs are disabled at this
Sigh. Copied/adjusted code again from the views/ version; fixing in both places.

[Avi (use Gerrit), 2010-10-07 14:55:24]

raz: ping?

[raz_google.com, 2010-10-07 19:48:25]

Yup, sorry, I reviewed the gtk version this morning and accidentally thought
I reviewed this one.

Looking now!

On Thu, Oct 7, 2010 at 9:55 AM, <avi@chromium.org> wrote:

> raz: ping?
>
>
> http://codereview.chromium.org/3590020/show
>

[Raz Mathias, 2010-10-07 20:15:59]

LGTM

http://codereview.chromium.org/3590020/diff/13001/14004
File chrome/browser/views/clear_server_data.cc (right):

http://codereview.chromium.org/3590020/diff/13001/14004#newcode288
chrome/browser/views/clear_server_data.cc:288: // This can occur on a first
start and after a failed clear (which does
Thanks for fixing spacing here!

http://codereview.chromium.org/3590020/diff/13001/14005
File chrome/browser/views/clear_server_data.h (right):

http://codereview.chromium.org/3590020/diff/13001/14005#newcode1
chrome/browser/views/clear_server_data.h:1: // Copyright (c) 2006-2008 The
Chromium Authors. All rights reserved.
Was property change in eol-style +LF intended?

[Avi (use Gerrit), 2010-10-07 20:20:36]

On 2010/10/07 20:15:59, raz wrote:
> Was property change in eol-style +LF intended?

Yes.

_All_ text files should have an eol-style of LF. When you added your files, the
pre-commit script should have complained to you that you didn't set the
eol-style. Please double-check your svn settings. See
http://dev.chromium.org/developers/coding-style in the section "Subversion
properties".

[raz_google.com, 2010-10-07 20:32:06]

Noted, thanks!

On Thu, Oct 7, 2010 at 3:20 PM, <avi@chromium.org> wrote:

> On 2010/10/07 20:15:59, raz wrote:
>
>> Was property change in eol-style +LF intended?
>>
>
> Yes.
>
> _All_ text files should have an eol-style of LF. When you added your files,
> the
> pre-commit script should have complained to you that you didn't set the
> eol-style. Please double-check your svn settings. See
> http://dev.chromium.org/developers/coding-style in the section "Subversion
> properties".
>
>
> http://codereview.chromium.org/3590020/show
>