Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 383993008: Revert of FileWriter should not use deprecated {,un}setPendingActivity (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)
Modified:
6 years, 5 months ago
Reviewers:
tzik, nhiroki, eseidel
CC:
blink-reviews, kinuko+fileapi
Project:
blink
Visibility:
Public.

Description

Revert of FileWriter should not use deprecated {,un}setPendingActivity (https://codereview.chromium.org/383103002/) Reason for revert: Leaks started in: file-metadata-after-write.html file-writer-abort-continue.html file-writer-abort-depth.html file-writer-abort.html file-writer-empty-blob.html file-writer-events.html file-writer-gc-blob.html file-writer-truncate-extend.html file-writer-write-overlapped.html filesystem-iframe-from-remote.html filesystem-url-in-iframe.html filesystem-urls-match-self.html not-enough-arguments.html op-get-metadata.html request-file-content.html request-metadata.html send-file-blob-fail.html send-file-blob.html shared-worker-constructor.html as of: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b... This seems like a likely candidate. Original issue's description: > FileWriter should not use deprecated {,un}setPendingActivity > > BUG=354845 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177936 TBR=nhiroki@chromium.org,tzik@chromium.org,eseidel@chromium.org NOTRY=true BUG=354845 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/modules/filesystem/FileWriter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/FileWriter.cpp View 6 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kouhei (in TOK)
Created Revert of FileWriter should not use deprecated {,un}setPendingActivity
6 years, 5 months ago (2014-07-12 01:26:23 UTC) #1
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-12 01:26:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/383993008/1
6 years, 5 months ago (2014-07-12 01:27:43 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 01:28:49 UTC) #4
Message was sent while issue was closed.
Change committed as 177988

Powered by Google App Engine
This is Rietveld 408576698