FileWriter should not use deprecated {,un}setPendingActivity

FileWriter should not use deprecated {,un}setPendingActivity

BUG=354845
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177936

[kouhei (in TOK), 2014-07-11 06:36:34]

r?

[tzik, 2014-07-11 06:55:47]

https://codereview.chromium.org/383103002/diff/1/Source/modules/filesystem/Fi...
File Source/modules/filesystem/FileWriter.cpp (right):

https://codereview.chromium.org/383103002/diff/1/Source/modules/filesystem/Fi...
Source/modules/filesystem/FileWriter.cpp:92: return m_operationInProgress !=
OperationNone || m_queuedOperation != OperationNone || m_readyState != DONE;
s/m_readyState != DONE/m_readyState == WRITING/?

[kouhei (in TOK), 2014-07-11 07:01:52]

PTAL

https://codereview.chromium.org/383103002/diff/1/Source/modules/filesystem/Fi...
File Source/modules/filesystem/FileWriter.cpp (right):

https://codereview.chromium.org/383103002/diff/1/Source/modules/filesystem/Fi...
Source/modules/filesystem/FileWriter.cpp:92: return m_operationInProgress !=
OperationNone || m_queuedOperation != OperationNone || m_readyState != DONE;
On 2014/07/11 06:55:47, tzik wrote:
> s/m_readyState != DONE/m_readyState == WRITING/?

Done.

[tzik, 2014-07-11 07:02:46]

lgtm

[kouhei (in TOK), 2014-07-11 07:03:12]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-07-11 07:05:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/383103002/20001

[commit-bot: I haz the power, 2014-07-11 08:13:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-07-11 09:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-11 09:23:25]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[kouhei (in TOK), 2014-07-11 11:31:32]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-07-11 11:32:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/383103002/20001

[commit-bot: I haz the power, 2014-07-11 12:35:02]

Change committed as 177936

[eseidel, 2014-07-11 16:19:51]

Leaks started in:
file-metadata-after-write.html 
file-writer-abort-continue.html 
file-writer-abort-depth.html 
file-writer-abort.html 
file-writer-empty-blob.html 
file-writer-events.html 
file-writer-gc-blob.html 
file-writer-truncate-extend.html 
file-writer-write-overlapped.html 
filesystem-iframe-from-remote.html 
filesystem-url-in-iframe.html 
filesystem-urls-match-self.html 
not-enough-arguments.html 
op-get-metadata.html 
request-file-content.html 
request-metadata.html 
send-file-blob-fail.html 
send-file-blob.html 
shared-worker-constructor.html 

as of:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...

This seems like a likely candidate.

[kouhei (in TOK), 2014-07-12 01:26:22]

A revert of this CL has been created in
https://codereview.chromium.org/383993008/ by kouhei@chromium.org.

The reason for reverting is: Leaks started in:
file-metadata-after-write.html 
file-writer-abort-continue.html 
file-writer-abort-depth.html 
file-writer-abort.html 
file-writer-empty-blob.html 
file-writer-events.html 
file-writer-gc-blob.html 
file-writer-truncate-extend.html 
file-writer-write-overlapped.html 
filesystem-iframe-from-remote.html 
filesystem-url-in-iframe.html 
filesystem-urls-match-self.html 
not-enough-arguments.html 
op-get-metadata.html 
request-file-content.html 
request-metadata.html 
send-file-blob-fail.html 
send-file-blob.html 
shared-worker-constructor.html 

as of:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...

This seems like a likely candidate.
.

[kouhei (in TOK), 2014-07-12 01:27:04]

eseidel: Thanks for noticing!