Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 383913002: MIPS: Use a register spec for StoreIC and KeyedStoreIC. (Closed)

Created:
6 years, 5 months ago by akos.palfi.imgtec
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Use a register spec for StoreIC and KeyedStoreIC. Port r22328 (92275b7a) Original commit message: This continues refactoring already applied for LoadIC in r22035 (https://code.google.com/p/v8/source/detail?r=22035). BUG= R=gergely@homejinni.com Committed: https://code.google.com/p/v8/source/detail?r=22336

Patch Set 1 #

Patch Set 2 : Addressed comments. #

Patch Set 3 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -301 lines) Patch
M src/mips/code-stubs-mips.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/mips/debug-mips.cc View 1 1 chunk +12 lines, -16 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 8 chunks +25 lines, -22 lines 0 comments Download
M src/mips/ic-mips.cc View 11 chunks +51 lines, -80 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/mips64/debug-mips64.cc View 1 1 chunk +12 lines, -17 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 8 chunks +25 lines, -22 lines 0 comments Download
M src/mips64/ic-mips64.cc View 11 chunks +52 lines, -80 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/mips64/stub-cache-mips64.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
akos.palfi.imgtec
PTAL.
6 years, 5 months ago (2014-07-10 23:41:47 UTC) #1
kisg
On 2014/07/10 23:41:47, akos.palfi.imgtec wrote: > PTAL. LGTM
6 years, 5 months ago (2014-07-11 01:48:05 UTC) #2
akos.palfi.imgtec
6 years, 5 months ago (2014-07-11 01:50:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r22336 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698