Issue 383893003: Fixes two bugs in analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 383893003: Fixes two bugs in analyzer (Closed)

Created:
6 years, 5 months ago by sky

Modified:
6 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fixes two bugs in analyzer Wasn't delaing with relative paths outside the repo. NACL does this for things like /usr/include/... When combining relative paths I was missing adding a '/'. This result in paths like baseobserver_list.h instead of base/observer_list.h. BUG=383609 TEST=covered by unit tests R=mark@chromium.org

Patch Set 1 #

Patch Set 2 : better comments #

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -6 lines)			Patch
M	pylib/gyp/generator/analyzer.py	View	1 2	2 chunks	+20 lines, -6 lines	0 comments	Download
M	test/analyzer/gyptest-analyzer.py	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
A	test/analyzer/subdir/subdir2/subdir2.gyp	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	test/analyzer/test.gyp	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages