Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 383893003: Fixes two bugs in analyzer (Closed)

Created:
5 years, 2 months ago by sky
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fixes two bugs in analyzer Wasn't delaing with relative paths outside the repo. NACL does this for things like /usr/include/... When combining relative paths I was missing adding a '/'. This result in paths like baseobserver_list.h instead of base/observer_list.h. BUG=383609 TEST=covered by unit tests R=mark@chromium.org

Patch Set 1 #

Patch Set 2 : better comments #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -6 lines) Patch
M pylib/gyp/generator/analyzer.py View 1 2 2 chunks +20 lines, -6 lines 0 comments Download
M test/analyzer/gyptest-analyzer.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A test/analyzer/subdir/subdir2/subdir2.gyp View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M test/analyzer/test.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
5 years, 2 months ago (2014-07-11 00:07:37 UTC) #1
Mark Mentovai
5 years, 2 months ago (2014-07-11 00:24:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698